Skip to content

Fix feed pagination offset for mixed items#14430

Merged
raymondjacobson merged 1 commit into
mainfrom
codex/fix-feed-pagination-offset
Jun 1, 2026
Merged

Fix feed pagination offset for mixed items#14430
raymondjacobson merged 1 commit into
mainfrom
codex/fix-feed-pagination-offset

Conversation

@raymondjacobson
Copy link
Copy Markdown
Member

Summary

  • advance Latest feed pagination by the number of mixed feed items returned, not only tracks
  • align the client offset with the API contract for /v1/users/{id}/feed, which applies OFFSET over tracks + collections
  • prevents overlapping/repeated pages when collections are present in the feed

Context

Past commits introduced mixed feed rendering and then changed Latest feed pagination to count only track entries. That makes the client request page 2 with an offset that is too small whenever page 1 includes collections. Example: 6 tracks + 4 collections with limit 10 requests offset 6 instead of 10, so the next API page overlaps already-rendered items and can make pagination feel stuck.

The API history also shows separate server-side feed perf fixes (#798 for Latest feed planner cliffs, #805/#806/#817 for For You timeouts). This PR addresses the current client-side mixed-item offset mismatch.

Testing

  • git diff --check

Could not run TypeScript locally because this worktree has no node_modules and the shell has node but no npm/npx installed.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 1, 2026

⚠️ No Changeset found

Latest commit: 0d6c447

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

🌐 Web preview ready

Preview URL: https://audius-web-preview-pr-14430.audius.workers.dev

Unique preview for this PR (deployed from this branch).
Workflow run

@raymondjacobson raymondjacobson merged commit ec52f74 into main Jun 1, 2026
13 checks passed
@raymondjacobson raymondjacobson deleted the codex/fix-feed-pagination-offset branch June 1, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant