chore: remove legacy lineup scaffolding#14439
Merged
Merged
Conversation
The lineup engine is fully migrated to tan-query hooks + the playback slice; the legacy uid-based redux-saga lineup system has no remaining live consumers. Remove the dead scaffolding: - Delete common/store/lineup (actions, reducer, selectors, registry, LineupBaseActions). Not wired into any store; zero consumers besides vestigial type props. Drop its barrel re-export from store/index. - Delete mobile CollectionLineupCarousel — dead code (no source references), the only component still calling the legacy uid-based actions.togglePlay(uid, id, source). - Drop the vestigial `actions?: LineupBaseActions` prop from the mobile lineup tile/types (never read by TrackTile/CollectionTile) and the `actions: LineupBaseActions` fields from the unused legacy Lineup prop types. tsc --noEmit clean in common, mobile, and web. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: f1b8777 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🌐 Web preview readyPreview URL: https://audius-web-preview-pr-14439.audius.workers.dev Unique preview for this PR (deployed from this branch). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the dead, uid-based legacy lineup scaffolding. The lineup engine is already fully migrated to tan-query hooks (
useFeed,useTrending,useProfileTracks, …) + the playback slice +TrackLineup— there were no legacy lineups left to migrate, only orphaned infrastructure.Why
Investigation (follow-up to the playback-uid cleanup, #14438) showed the classic lineup system is gone: zero
makeLineupActions/LineupSagasin source, andcommon/store/lineup's reducer/registry is not wired into any store. The remaining surface had no live consumers.Changes
packages/common/src/store/lineup/(actions,reducer,selectors,registry,LineupBaseActions) and drop its barrel re-export fromstore/index.ts. Verified: no direct-path imports, no symbol imports, not registered in any store. (actionsMaphits elsewhere are unrelated local reducer consts.)mobile/.../explore-screen/components/CollectionLineupCarousel.tsx— dead code (no source references anywhere), the only component still calling the legacyactions.togglePlay(uid, id, source). Explore itself usesuseExploreContent.LineupBaseActionsusage from the mobile types: theactions?: LineupBaseActionsprop onlineup-tile/types.ts(never read byTrackTile/CollectionTile) and theactions: LineupBaseActionsfields on the unused legacyLineup*prop types inlineup/types.ts.Verification
tsc --noEmitclean in common, mobile, and web (0 errors each) — the gate that confirms nothing leaned on the deleted module.@audius/commonpatch) since this trims that package's exports.Not touched (out of scope)
common/store/sagas.tsthat lists old web saga paths (incl.store/lineup/sagas.js) — stale but unrelated.CardLineup/InfiniteCardLineup) — presentational collection-card grids, not the uid/playback lineup system.🤖 Generated with Claude Code