Conversation
yousifS
reviewed
Jun 11, 2020
| , Winner = 'Hand one wins!' | ||
| , Tie = "It's a tie!"; | ||
|
|
||
| if (i == ii) { |
There was a problem hiding this comment.
while this will work, it seems a little convoluted, since it is no clear right away how i, ii, and sumN work together.
Author
|
Thank you Yousif! I’ll use more descriptive words.
From: yousifS <notifications@github.com>
Sent: Thursday, June 11, 2020 1:01 AM
To: AustinCodingAcademy/JS211_RockPaperScissorsProject <JS211_RockPaperScissorsProject@noreply.github.com>
Cc: DavidCastillo4 <David.Castillo4@gmail.com>; Author <author@noreply.github.com>
Subject: Re: [AustinCodingAcademy/JS211_RockPaperScissorsProject] Rps (#8)
@yousifS commented on this pull request.
_____
In main.js <#8 (comment)> :
+ if (i == ii) {
while this will work, it seems a little convoluted, since it is no clear right away how i, ii, and sumN work together.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#8 (review)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIVBPPQQXH5WMLZFBPBUFDDRWBXJ3ANCNFSM4NSACAYQ> . <https://github.com/notifications/beacon/AIVBPPTFM7EFODVG2YBAODTRWBXJ3A5CNFSM4NSACAY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODGGB4OI.gif>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3