You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@OfryL@dorshay6 I think using Github labels would be easier:
It would allow selecting one without the need of editing the description, it would be more visible (no need to enter PR in order to see it) and we could search PRs based on it much easier...
@OfryL@dorshay6 I think using Github labels would be easier: It would allow selecting one without the need of editing the description, it would be more visible (no need to enter PR in order to see it) and we could search PRs based on it much easier...
Relevant labels were added in org level, this will effect new repos only.
Relevant labels were added in org level, this will effect new repos only.
@OfryL I think we should prefer labels due to their advantages, and add them as we go... (anyone opening a PR in a repo which doesn't have the labels yet should add them to that repo)
@atlowChemi how would these labels work? @OfryL i think the risk assesment should stay in the jira, to be our source of truth (these might change and we don't want to change it in 2 places)
i also think the meaningful descriptions should be elaborate
also add a unit test square and todo section (maybe stuff left until finished)
Not sure what you mean by "work".
An individual opening a PR would mark the PR with the relevant label based on his assumption.
This would allow the reviewers to be more alert when reviewing yellow/red PRs, and it would allow having a documented discussion if someone disagrees with the risk assessment...
@OfryL i think the risk assesment should stay in the jira, to be our source of truth (these might change and we don't want to change it in 2 places)
We could add a GHA that updates Jira by API when a PR label is changed...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ PR description:
updating pr template to our new flow
📋 PR tasks:
Footnotes
Deploy By Risk Level – FigJam ↩