Skip to content

Normalize button diagnostic style shorthands#576

Merged
chubes4 merged 1 commit into
trunkfrom
cook/residual-saas-button-diagnostics
Jul 7, 2026
Merged

Normalize button diagnostic style shorthands#576
chubes4 merged 1 commit into
trunkfrom
cook/residual-saas-button-diagnostics

Conversation

@chubes4

@chubes4 chubes4 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Normalize border shorthand/longhand forms before button visual probe comparison.
  • Normalize wrapper chrome comparison through the same comparable style groups so equivalent padding/border syntax does not produce false residual causes.
  • Add unit coverage for equivalent border and wrapper shorthand/longhand diagnostics.

Diagnostic evidence

  • Before, current trunk SaaS button probe reported 6 style deltas and causes: button_border_mismatch=4, button_text_color_mismatch=2, button_wrapper_chrome_mismatch=8.
  • After, SaaS button probe reports 2 style deltas and causes: button_text_color_mismatch=2, button_wrapper_chrome_mismatch=3.
  • Artist remains unchanged: real button_default_style_leakage=9, button_border_missing=9, button_text_color_mismatch=10, button_padding_missing=4, button_fill_missing=1, button_wrapper_chrome_mismatch=3.

Verification

  • composer test
  • php tools/static-parity/run.php --fixture 15-saas --json
  • php tools/static-parity/run.php --fixture 3-artist-music --json

AI assistance

  • AI assistance: Yes
  • Tool(s): GPT-5.5 via OpenCode
  • Used for: Investigated residual SaaS/Artist button diagnostics, implemented the comparator normalization, added tests, and ran verification.

@chubes4 chubes4 merged commit 07eea9b into trunk Jul 7, 2026
1 check passed
@chubes4 chubes4 deleted the cook/residual-saas-button-diagnostics branch July 7, 2026 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant