[codex] Harden WP UI nonce E2E helper#49
Open
adamziel wants to merge 15 commits into
Open
Conversation
a2960af to
627586d
Compare
627586d to
959bca4
Compare
959bca4 to
8dd09b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set +eso the caller can dump admin/login HTML and logsWhy
The merged PR #46 CI run exposed a COW E2E failure before the WordPress admin branch-create request was submitted. The helper exited while extracting the branch UI nonce, but the command substitution path hid the page contents that would explain the failure. This keeps the test focused on branch behavior and makes auth, redirect, and markup failures diagnosable.
The first revisions still exited without useful diagnostics on Linux/macOS because
errexitcould leave from inside the helper before the caller printed dumps. This revision captures the helper status explicitly.Validation
bash -n tests/cow/e2e.shgit diff --checkumask 022; php tests/cow/branch_ui.php(25 assertions)