feat(my-account): improve navigation on small screens#4471
Open
thomasguillot wants to merge 2 commits intotrunkfrom
Open
feat(my-account): improve navigation on small screens#4471thomasguillot wants to merge 2 commits intotrunkfrom
thomasguillot wants to merge 2 commits intotrunkfrom
Conversation
641f8cd to
c69499a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR modifies the appearance of the navigation on small screens.
The header is now branded with the primary colour to clearly differentiate it from the front end and make it obvious that users are in a different part of the site. This is especially helpful on mobile, where things can get confusing more easily. Using the primary colour also ties in nicely with the menu when it’s open, since the current page is highlighted with the same colour.
I’ve tweaked the behaviour and padding of the navigation when it’s opened. There was an issue on very small screens (under 601px) where the menu’s top position was based on the admin bar. If the user scrolled, this caused a large gap because the admin bar isn’t fixed at that breakpoint.
I also made the header sticky so users can always access the navigation.
How to test the changes in this Pull Request:
Other information: