feat(data-events): add ActionScheduler logging and retry reason#4488
Open
miguelpeixe wants to merge 6 commits intofeat/data-events-sync-queuefrom
Open
feat(data-events): add ActionScheduler logging and retry reason#4488miguelpeixe wants to merge 6 commits intofeat/data-events-sync-queuefrom
miguelpeixe wants to merge 6 commits intofeat/data-events-sync-queuefrom
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
NPPD-1238
Depends on Automattic/newspack-newsletters#2031.
Implements AS logging and a
reasonproperty to retry actions for data events and syncs.The sync method will return multiple errors, so the logged string will be the joined error messages rather than the usual
->get_error_message(), which returns the first error message from the object.Automattic/newspack-newsletters#2031 is required because the upsert errors were no longer exposed in favor of a reader-friendly message. The proposed change is to compose a new
WP_Errorobject with all the errors, with the generic reader-friendly message first so it's used in UIs.How to test the changes in this Pull Request:
/wp-admin/admin.php?page=wc-status&tab=action-schedulernewspack_contact_sync_retryreasonin the argsOther information: