[Tooling] Upload CDN builds as internal first, publish as external later#2689
Closed
[Tooling] Upload CDN builds as internal first, publish as external later#2689
Conversation
…ish_release Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the release tooling flow so release build artifacts are uploaded to the Apps CDN as Internal first, then flipped to External during publish_release, enabling an internal testing window between finalize and publish.
Changes:
- Uploads Apps CDN artifacts with
visibility: internalduringdistribute_builds. - Stores CDN post IDs in the draft GitHub release body as an HTML comment for later retrieval.
- Adds a
publish_releasestep to read those IDs and update CDN visibility to External before publishing the GitHub release.
Comments suppressed due to low confidence (1)
fastlane/Fastfile:665
- In dry-run mode this returns
post_id: 0, which is truthy and could be mistaken for a real post ID if reused elsewhere. Returningnil(or omittingpost_id) would better reflect “unknown / not created”.
return {
media_url: media_url,
post_id: 0
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… missing CDN post IDs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…elease Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
PR superseded by #2695 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
visibility: internal(Automatticians-only) duringfinalize_release/distribute_release_build, instead ofexternalpublish_release, read the draft release body, extract post IDs, and callupdate_apps_cdn_build_metadatafor each build to flip visibility toexternalbefore publishing the GitHub releaseDepends on: wordpress-mobile/release-toolkit PR for the new
update_apps_cdn_build_metadataaction.Testing Instructions
update_apps_cdn_build_metadataaction needs to be manually verified against the WPCOM API first (see release-toolkit PR)finalize_release→ verify builds appear on CDN with Internal visibilitypublish_release→ verify builds are updated to External visibility and GitHub release is publishedPre-merge Checklist
🤖 Generated with Claude Code