Make readdir ordering deterministic#49
Open
joliss wants to merge 1 commit intoAvianFlu:masterfrom
Open
Conversation
The .sort is extremely fast, and it cannot hurt to make things deterministic, to avoid flickering tests for instance.
Contributor
Author
|
I think Travis is just having a hiccup, the test suite passes on Node 0.8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The .sort is extremely fast, and it cannot hurt to make things
deterministic, to avoid flickering tests for instance.
This is borderline bikesheddy, but I noticed the
readdircall withoutsortwhen I read the source. I like to protect all myreaddircalls (as well asObject.keysand friends) with.sortto keep my libraries deterministic.Please merge if you like, or close otherwise. :)