Harden image enhancement runtime and test coverage - #1
Merged
Merged
Conversation
- Introduced NSFW segmentation functionality in the LocalJobManager. - Added model validation for NSFW segmenter files during job execution. - Implemented cleanup for stale preview images without affecting final outputs. - Enhanced the UI to allow users to install and configure NSFW segmentation models. - Updated tests to cover new NSFW segmentation features and model requirements. - Modified the image worker to handle NSFW segmentation and save detected masks. - Improved error handling and user feedback for model installation processes.
- Implement image encoding functions in `images.ts` and corresponding tests in `images.test.ts`. - Create a new workspace state management system in `workspace.ts` with default values and normalization logic. - Add tests for workspace state management in `workspace.test.ts`. - Set up main entry point for the application in `main.tsx` with React and necessary styles. - Introduce type definitions in `types.ts` for better type safety across the application. - Add fixture scripts for job processing and MCP server testing. - Configure TypeScript and Vite for the project with appropriate settings.
- Introduced a new setting for user consent to view and generate NSFW content. - Updated the workspace state to include `nsfwConsent` and `nsfwDefaults`. - Modified the StudioView and SettingsView components to manage NSFW settings. - Implemented virtualized rendering for asset galleries to improve performance with large datasets. - Enhanced the LibraryView and StudioView to conditionally display NSFW assets based on user consent. - Added tests for new functionality and ensured existing tests cover changes.
- Implemented `warmChatModel` function to preload selected models with a keep-alive setting. - Updated `runMcpChat` to include model warming in the chat orchestration process. - Added IPC handler for warming models in the main process. - Integrated model warming into the App component to preload models based on user selection. - Enhanced ActivityView to conditionally display adult content based on NSFW consent. - Created tests for ActivityView to ensure proper handling of NSFW content visibility. - Refactored StudioView to remove unused asset rendering logic and improve performance. - Updated workspace normalization to mark assets linked to legacy adult runs as restricted. - Added utility functions for checking NSFW model tags.
…ctions - Added support for selecting regions of images for editing in the StudioView component. - Introduced new types for image editing, including `StudioImageEdit` and `ImageEditRegion`. - Updated the App component to handle NSFW content based on user consent. - Enhanced the ModelsView to conditionally display NSFW models based on consent. - Implemented tests for the new image editing features and NSFW consent handling. - Refactored CSS styles for improved layout and user experience in the editing interface.
Owner
Author
|
@copilot resolve the merge conflicts in this pull request |
# Conflicts: # README.md Co-authored-by: Azayzel <17281152+Azayzel@users.noreply.github.com>
Co-authored-by: Azayzel <17281152+Azayzel@users.noreply.github.com>
Co-authored-by: Azayzel <17281152+Azayzel@users.noreply.github.com>
Co-authored-by: Azayzel <17281152+Azayzel@users.noreply.github.com>
Co-authored-by: Azayzel <17281152+Azayzel@users.noreply.github.com>
Co-authored-by: Azayzel <17281152+Azayzel@users.noreply.github.com>
Co-authored-by: Azayzel <17281152+Azayzel@users.noreply.github.com>
Co-authored-by: Azayzel <17281152+Azayzel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm test(29 tests)npm run lintnpm run build.venv\Scripts\python.exe -m unittest discover -s tests\python -p "test_*.py" -v(4 tests).venv\Scripts\python.exe -m py_compile runtime\image_worker.py tests\python\test_image_worker.py2.5.1+cu121, Torchvision0.20.1+cu121, CUDA availability, and Spandrel/Ultralytics imports