Skip to content

fix: move Release and delete out of BlockingCall callback to prevent SIGBUS on macOS #21629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ludamad wants to merge 1 commit into from
+8 −4
Closed

fix: move Release and delete out of BlockingCall callback to prevent SIGBUS on macOS #21629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions barretenberg/cpp/src/barretenberg/nodejs_module/util/async_op.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,12 @@ class ThreadedAsyncOperation {
_success = false;
}

// Post completion back to the JS main thread
// Post completion back to the JS main thread.
// Release and delete must happen AFTER BlockingCall returns on this thread,
// not inside the callback. Release() drops the TSFN refcount to 0, which can
// tear down internal state (mutex/condvar) that BlockingCall still needs to
// unwind through. Doing either inside the callback caused SIGBUS on macOS
// (magazine malloc unmaps freed pages) and segfaults on Linux.
_completion_tsfn.BlockingCall(
this, [](Napi::Env env, Napi::Function /*js_callback*/, ThreadedAsyncOperation* op) {
if (op->_success) {
Expand All @@ -124,10 +129,9 @@ class ThreadedAsyncOperation {
auto error = Napi::Error::New(env, op->_error);
op->_deferred->Reject(error.Value());
}
// Release the TSFN and self-destruct
op->_completion_tsfn.Release();
delete op;
});
_completion_tsfn.Release();
delete this;
}).detach();
}

Expand Down
Loading