Repository navigation
Conversation
- Deploy script header described the old deployer-owned-then-transferred flow; the rollup is owned by governance from construction. - State which values verify() does not read back. - Runbook: drop the incorrect 'totalEarmarkedBalance must be 0' precondition (earmarks stay claimable and subsidizeAddress cannot shrink the implicit pool); check availableTo(v5) covers the reservation instead. - Runbook: list the six library deployments and the measured gas, add a verifier bytecode check, fix action numbers, fill in placeholder commands.
AztecBot
added
ci-draft
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #25626 onto
v6. It contains Santiago Palladino's single commitcb767bf4with his authorship kept. Docs and comments only; no Solidity code changes.Why a replacement PR
#25626 was stacked on #25601's branch (
amin/v6-upgrade-payload). #25601 was squash-merged intov6and its branch deleted, so GitHub retargeted #25626 tov6. It still carried the 13 commits #25601 had before the squash, and GitHub marked it as conflicting. ClaudeBox cannot push tospl/v6-upgrade-docs-fixes, so this PR carries the same commit cherry-picked ontov6(edf8e9a6). The cherry-pick applied without conflicts.The resulting tree is byte-identical to #25626's head (
git diffagainst it is empty), so the diff here is exactly Santiago's change: 4 files, +59/−30.Change (from #25626)
verify()does not check: entry-queue config, reward-boost parameters,ethereumSlotDuration, and verifier bytecode.availableTo(v5)must cover the 1.8M reservation). It also adds an owner check for the old flush rewarder, defines$TOKEN, and records a 2026-10-08 baseline.castcommands in the post-execution checks with real ones.V6UpgradePayload.mdrewrites the earmark limitation to match the distributor's behavior.Checks
forge fmt --checkpasses on the two touched.solfiles.Supersedes #25626. Close it once this merges.
Created by claudebox · group:
slackbot· requested by Mike (@iAmMichaelConnor) · Slack thread