Skip to content

fix: update go to 1.26 and run go fix #8010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timmy-wright wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: update go to 1.26 and run go fix #8010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ecd96df
update go
timmy-wright Mar 4, 2026
56199c4
update go in pipelines
timmy-wright Mar 4, 2026
ac1541e
update golintci
timmy-wright Mar 4, 2026
acee38d
lint fixes
timmy-wright Mar 4, 2026
ed7c375
nosec
timmy-wright Mar 4, 2026
c1f3b21
space
timmy-wright Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check-coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
if: success()
uses: actions/setup-go@v6
with:
go-version: '1.24'
go-version: '1.26'
- name: Checkout code
uses: actions/checkout@v6
- name: Run unit tests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/copilot-setup-steps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:

- uses: actions/setup-go@v6
with:
go-version: '1.24'
go-version: '1.26'

- run: |
set -ex
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/go-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
- uses: actions/checkout@v6
- uses: actions/setup-go@v6
with:
go-version: '1.24'
go-version: '1.26'
- run: |
set -ex
make test
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/golangci-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ jobs:
steps:
- uses: actions/setup-go@v6
with:
go-version: '1.24'
go-version: '1.26'
- uses: actions/checkout@v6
- name: golangci-lint
uses: golangci/golangci-lint-action@v9
with:
# Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
version: v2.8.0
version: v2.10.1
working-directory: ${{ matrix.dirs }}

# Optional: working directory, useful for monorepos
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/shellcheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
- uses: actions/checkout@v6
- uses: actions/setup-go@v6
with:
go-version: '1.24'
go-version: '1.26'
- run: |
make validate-shell
name: Lint shell/bash scripts with ShellCheck
2 changes: 1 addition & 1 deletion .github/workflows/shellspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
- uses: actions/checkout@v6
- uses: actions/setup-go@v6
with:
go-version: '1.24'
go-version: '1.26'
- run: |
make shellspec-ci
name: Run shell/bash script unit tests with shellspec
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/validate-components.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
- uses: actions/checkout@v6
- uses: actions/setup-go@v6
with:
go-version: '1.24'
go-version: '1.26'
- name: Install cue
run: |
go version
Expand Down Expand Up @@ -46,7 +46,7 @@ jobs:
- uses: actions/checkout@v6
- uses: actions/setup-go@v6
with:
go-version: '1.24'
go-version: '1.26'
- name: Run GPU managed components version consistency test
working-directory: ./e2e
run: |
Expand Down
2 changes: 1 addition & 1 deletion aks-node-controller/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/Azure/agentbaker/aks-node-controller

go 1.24.12
go 1.26.0

require (
github.com/Azure/agentbaker v0.20240503.0
Expand Down
4 changes: 2 additions & 2 deletions aks-node-controller/parser/helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,15 +478,15 @@ func createSortedKeyValuePairs[T any](m map[string]T, delimiter string) string {

// we are sorting the keys for deterministic output for readability and testing.
sort.Strings(keys)
var buf bytes.Buffer
buf := &bytes.Buffer{}
i := 0
for _, key := range keys {
i++
// set the last delimiter to empty string
if i == len(keys) {
delimiter = ""
}
buf.WriteString(fmt.Sprintf("%s=%v%s", key, m[key], delimiter))
fmt.Fprintf(buf, "%s=%v%s", key, m[key], delimiter)
}
return buf.String()
}
Expand Down
2 changes: 2 additions & 0 deletions apiserver/getnodebootstrapdata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@

nodeBootStrapping, err := agentBaker.GetNodeBootstrapping(ctx, &config)
if err != nil {
//nolint: gosec

Check failure on line 49 in apiserver/getnodebootstrapdata.go

View workflow job for this annotation

GitHub Actions / lint (.) 

directive `//nolint: gosec` should provide explanation such as `//nolint: gosec // this is why` (nolintlint)
log.Println(err.Error())
http.Error(w, err.Error(), http.StatusBadRequest)
return
Expand All @@ -58,5 +59,6 @@
}

w.WriteHeader(http.StatusOK)
//nolint: gosec

Check failure on line 62 in apiserver/getnodebootstrapdata.go

View workflow job for this annotation

GitHub Actions / lint (.) 

directive `//nolint: gosec` should provide explanation such as `//nolint: gosec // this is why` (nolintlint)
fmt.Fprint(w, string(result))
Comment on lines 49 to 63
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid broad // nolint: gosec here. fmt.Fprint(w, ...) returns an error that can be handled cheaply (e.g., log/return on write failure), which is preferable to suppressing gosec; similarly the log.Println line typically shouldn't need a gosec suppression. If a suppression is truly needed, use the narrow // #nosec <rule-id> form with a brief justification.

Copilot uses AI. Check for mistakes.
}
Loading
Loading