Skip to content

chore: update ACL os-release ID from 'acl' to 'azurecontainerlinux'#8035

Merged
cameronmeissner merged 1 commit intomainfrom
aadagarwal/acl-os-release
Mar 9, 2026
Merged

chore: update ACL os-release ID from 'acl' to 'azurecontainerlinux'#8035
cameronmeissner merged 1 commit intomainfrom
aadagarwal/acl-os-release

Conversation

@aadhar-agarwal
Copy link
Contributor

@aadhar-agarwal aadhar-agarwal commented Mar 6, 2026

The acl-scripts repo changed the os-release ID from 'acl' to 'azurecontainerlinux'. Update all AgentBaker detection logic, VHD build config, and tests to match.

  • Change ACL_OS_NAME constant from "ACL" to "AZURECONTAINERLINUX"
  • Update sysext extension-release ID in acl-customdata.yaml/json
  • Update direct $ID checks in init-aks-custom-cloud scripts
  • Update e2e test to validate ID=azurecontainerlinux
  • Regenerate snapshot testdata

[TEST All VHDs] AKS Linux VHD Build - https://msazure.visualstudio.com/CloudNativeCompute/_build/results?buildId=156027563&view=results

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Copilot AI review requested due to automatic review settings March 6, 2026 22:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Azure Container Linux (ACL) handling across AgentBaker to match upstream os-release ID change from acl to azurecontainerlinux, spanning provisioning scripts, VHD build inputs, and e2e/snapshot test artifacts.

Changes:

  • Update ACL OS name/constants and distro detection to align with ID=azurecontainerlinux.
  • Update ACL sysext extension-release metadata in Flatcar/Ignition customdata.
  • Refresh e2e assertions and regenerated snapshot testdata to reflect the new ID.

Reviewed changes

Copilot reviewed 42 out of 82 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
vhdbuilder/packer/test/linux-vhd-content-test.sh Updates ACL OS constant used by VHD content tests.
vhdbuilder/packer/post-install-dependencies.sh Updates ACL OS constant for post-install logic.
vhdbuilder/packer/install-ig.sh Updates ACL/Flatcar/Mariner skip condition to use constants.
vhdbuilder/packer/acl-customdata.yaml Updates sysext extension-release ID to azurecontainerlinux.
vhdbuilder/packer/acl-customdata.json Same as YAML, in JSON-encoded ignition payload.
pkg/agent/testdata/MarinerV2+Kata/CustomData Regenerated snapshot test data (binary gzip payload).
pkg/agent/testdata/MarinerV2+CustomCloud/CustomData Regenerated snapshot test data (binary gzip payload).
pkg/agent/testdata/CustomizedImageLinuxGuard/CustomData Regenerated snapshot test data (binary gzip payload).
pkg/agent/testdata/CustomizedImageKata/CustomData Regenerated snapshot test data (binary gzip payload).
pkg/agent/testdata/CustomizedImage/CustomData Regenerated snapshot test data (binary gzip payload).
parts/linux/cloud-init/artifacts/init-aks-custom-cloud.sh Updates /etc/os-release ID check for ACL detection.
parts/linux/cloud-init/artifacts/init-aks-custom-cloud-operation-requests.sh Same ACL ID detection update.
parts/linux/cloud-init/artifacts/cse_helpers.sh Updates ACL OS constant used by CSE helper logic.
e2e/scenario_test.go Updates ACL e2e validation to expect ID=azurecontainerlinux.
e2e/config/vhd.go Changes e2e OS selector value for ACL to azurecontainerlinux.
.pipelines/.vsts-vhd-builder-release.yaml Updates SIG source image name/version used by ACL VHD build job.

@aadhar-agarwal aadhar-agarwal changed the title Update ACL os-release ID from 'acl' to 'azurecontainerlinux' chore: update ACL os-release ID from 'acl' to 'azurecontainerlinux' Mar 6, 2026
@aadhar-agarwal aadhar-agarwal force-pushed the aadagarwal/acl-os-release branch from ac43095 to e346f2d Compare March 6, 2026 22:50
@cameronmeissner
Copy link
Contributor

/lgtm

@aadhar-agarwal aadhar-agarwal force-pushed the aadagarwal/acl-os-release branch from e346f2d to 549e55a Compare March 6, 2026 23:56
Copilot AI review requested due to automatic review settings March 6, 2026 23:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 42 out of 82 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

parts/linux/cloud-init/artifacts/init-aks-custom-cloud.sh:20

  • This OS detection change drops support for older Azure Container Linux images that still report ID=acl in /etc/os-release. In that case, the script will hit the "Unknown Linux distribution" branch and exit 1, which can break custom-cloud initialization. Consider accepting both IDs (e.g., treat acl and azurecontainerlinux as ACL) during the 6‑month compatibility window, or add a clear migration guard/telemetry before removing the old value.
    elif [[ $ID == *"flatcar"* ]]; then
        IS_FLATCAR=1
    elif [[ $ID == "azurecontainerlinux" ]]; then
        IS_ACL=1
    else
        echo "Unknown Linux distribution"
        exit 1

parts/linux/cloud-init/artifacts/init-aks-custom-cloud-operation-requests.sh:20

  • This OS detection change drops support for older Azure Container Linux images that still report ID=acl in /etc/os-release. If such an image runs this script, it will exit via the "Unknown Linux distribution" branch, potentially breaking operation-requests handling. Consider accepting both acl and azurecontainerlinux as ACL until older images are out of support.
    elif [[ $ID == *"flatcar"* ]]; then
        IS_FLATCAR=1
    elif [[ $ID == "azurecontainerlinux" ]]; then
        IS_ACL=1
    else
        echo "Unknown Linux distribution"
        exit 1

@aadhar-agarwal aadhar-agarwal force-pushed the aadagarwal/acl-os-release branch from 549e55a to d648b08 Compare March 7, 2026 00:31
Copilot AI review requested due to automatic review settings March 7, 2026 00:37
@aadhar-agarwal aadhar-agarwal force-pushed the aadagarwal/acl-os-release branch from d648b08 to 9541acf Compare March 7, 2026 00:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 42 out of 82 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (2)

parts/linux/cloud-init/artifacts/init-aks-custom-cloud.sh:20

  • This OS detection only matches ID=azurecontainerlinux. For backward compatibility, older ACL images that still have ID=acl will hit the "Unknown Linux distribution" path and exit 1, breaking the custom-cloud init flow. Consider accepting both IDs (e.g., [[ $ID == "acl" || $ID == "azurecontainerlinux" ]]).
    elif [[ $ID == "azurecontainerlinux" ]]; then
        IS_ACL=1
    else
        echo "Unknown Linux distribution"
        exit 1

parts/linux/cloud-init/artifacts/init-aks-custom-cloud-operation-requests.sh:20

  • This OS detection only matches ID=azurecontainerlinux. For backward compatibility, older ACL images that still have ID=acl will hit the "Unknown Linux distribution" path and exit 1, breaking the operation-requests init flow. Consider accepting both IDs (e.g., [[ $ID == "acl" || $ID == "azurecontainerlinux" ]]).
    elif [[ $ID == "azurecontainerlinux" ]]; then
        IS_ACL=1
    else
        echo "Unknown Linux distribution"
        exit 1

@aadhar-agarwal aadhar-agarwal force-pushed the aadagarwal/acl-os-release branch from 9541acf to a29a561 Compare March 7, 2026 00:54
@aadhar-agarwal aadhar-agarwal force-pushed the aadagarwal/acl-os-release branch from a29a561 to 327e2d8 Compare March 9, 2026 20:00
Copilot AI review requested due to automatic review settings March 9, 2026 20:00
@aadhar-agarwal aadhar-agarwal marked this pull request as ready for review March 9, 2026 20:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 42 out of 83 changed files in this pull request and generated no new comments.

Signed-off-by: Aadhar Agarwal <aadagarwal@microsoft.com>
@cameronmeissner cameronmeissner merged commit cb478da into main Mar 9, 2026
21 of 37 checks passed
@cameronmeissner cameronmeissner deleted the aadagarwal/acl-os-release branch March 9, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants