feat: add property TestMode for some force e2e test#8076
Merged
Conversation
fseldow
requested review from
AbelHu,
Devinwong,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an e2e-only “test mode” flag to the private egress/security profile model and exposes it through the template function map (intended to support network-isolated cluster scenarios).
Changes:
- Add
TestModetodatamodel.PrivateEgressplus aSecurityProfilegetter (GetPrivateEgressTestMode). - Add a new template function
GetNetworkIsolatedClusterTestModeto the AgentBaker template func map.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/agent/datamodel/types.go | Adds PrivateEgress.TestMode and a corresponding getter on SecurityProfile. |
| pkg/agent/baker.go | Exposes the new flag via the template func map for template/script generation. |
djsly
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
feat: add property TestMode for some force e2e test
Then we can replace VMSS tag for forcePMC in network isolated cluster to avoid cached packages skip the download logic, and partially allow custom script in windows node for easier e2e test.
Which issue(s) this PR fixes:
Fixes #