Azure VMware Solution: adding KQL Queries for "Use key autorotation for vSAN datastore customer-managed keys" and "Use Azure Boost VMs for Maintenance sensitive workload VMs"#796
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a KQL query to validate the "Use key autorotation for vSAN datastore customer-managed keys" recommendation for Azure VMware Solution (AVS) private clouds. The query replaces a placeholder indicating the recommendation could not be validated with Azure Resource Graph.
Key Changes
- Implements a KQL query that identifies encryption types (Customer-managed vs Microsoft-managed keys) for AVS private clouds
- Extracts and displays key vault properties including keyName and keyVaultId for resources using customer-managed keys
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1 +1,12 @@ | |||
| // cannot-be-validated-with-arg | |||
| // Azure Resource Graph Query | |||
| // This query will return if the encryptionType is Customer-managed key or Microsoft-Managed key. If it is Customer-managed key, the query displays the keyName and keyVaultId | |||
There was a problem hiding this comment.
Inconsistent capitalization: 'Customer-managed key' should be 'Customer-managed keys' and 'Microsoft-Managed key' should be 'Microsoft-managed keys' to match the actual output values in the query.
| // This query will return if the encryptionType is Customer-managed key or Microsoft-Managed key. If it is Customer-managed key, the query displays the keyName and keyVaultId | |
| // This query will return if the encryptionType is Customer-managed keys or Microsoft-managed keys. If it is Customer-managed keys, the query displays the keyName and keyVaultId |
| @@ -1 +1,12 @@ | |||
| // cannot-be-validated-with-arg | |||
| // Azure Resource Graph Query | |||
| // This query will return if the encryptionType is Customer-managed key or Microsoft-Managed key. If it is Customer-managed key, the query displays the keyName and keyVaultId | |||
There was a problem hiding this comment.
The comment describes what the query returns but doesn't explain its purpose in the context of key autorotation validation. Consider adding a description of what the query is checking for (e.g., identifying private clouds that need key autorotation configured).
| // This query will return if the encryptionType is Customer-managed key or Microsoft-Managed key. If it is Customer-managed key, the query displays the keyName and keyVaultId | |
| // This query identifies AVS private clouds and determines whether they use customer-managed or Microsoft-managed keys, to help validate if key autorotation is required or properly configured. If customer-managed keys are used, the query displays the keyName and keyVaultId for further assessment. |
@microsoft-github-policy-service agree company="Microsoft" |
Overview/Summary
Related Issues/Work Items
Breaking Changes
As part of this pull request I have
mainbranch