Conversation
|
|
why is this? |
| @@ -0,0 +1,9 @@ | |||
| function GetAvdSessionHostName { | |||
There was a problem hiding this comment.
are there any changes in the dsc folder or is it just copy pasted?
There was a problem hiding this comment.
I just copy pasted the DSC folder as I didn't see anything needing to be changed
There was a problem hiding this comment.
Maybe we should refactor the dsc folder out and use the same one for both arm and bicep templates
|
The reason they have to be hardcoded is because BICEP doesn't allow string interpolation in its resource variables, so it is expecting an specific data format like foo@bar, where bar is ApiVersion. Because it prevents interpolation, the quickest solution (and possibly only) solution is to hardcode the ApiVersions. See here: https://docs.microsoft.com/en-us/azure/azure-resource-manager/bicep/resource-declaration?tabs=azure-powershell (Note: There may be a way around this, but I didn't know if it was worth pursuing or not. |
|
It is unnecessary for github i think |
|
Wondering why there are separate files for Availability set, workspace, networksecurity group which is different from arm template |
1 similar comment
|
Wondering why there are separate files for Availability set, workspace, networksecurity group which is different from arm template |
| param availabilitySetTags object | ||
| param availabilitySetUpdateDomainCount int | ||
| param availabilitySetFaultDomainCount int | ||
| param avSetSKU string |
There was a problem hiding this comment.
Why there are two AVSet linked template
Fixed all errors that arose during manual deployment testing.
4 participants
Bicep implementation for all ARM templates hosted in the GitHub. One major change that is required is THE API VERSION MUST BE HARDCODED, so when we want to change apiVersions, we must manually update to a newer version.