Skip to content

aks-desktop: Bump deps using npm audit fix - #962

Draft
evangelos (skoeva) wants to merge 1 commit into
Azure:mainfrom
skoeva:aksd-deps
Draft

evangelos (skoeva) wants to merge 1 commit into
Azure:mainfrom
skoeva:aksd-deps

Conversation

@skoeva

Copy link
Copy Markdown
Collaborator

No description provided.

@skoeva evangelos (skoeva) self-assigned this Sep 11, 2026
Copilot AI lite review requested due to automatic review settings September 11, 2026 15:26
@skoeva evangelos (skoeva) added dependencies Pull requests that update a dependency file security labels Sep 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Restore SHA-512 integrity metadata and maintain compatibility with the supported Node 20 toolchain.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Refreshes the AKS Desktop npm lockfile via npm audit fix.

Changes:

  • Updates Azure Identity/MSAL, Babel, Vitest, Vite, and transitive dependencies.
  • Adds @azure/core-process.
  • Regenerates lockfile integrity metadata.
File summaries
File Summary
plugins/aks-desktop/package-lock.json Contains moderate issues: SHA-512 integrity metadata was replaced with SHA-1, and updated dependencies require Node 22 while CI uses Node 20.
Review details

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)

  • plugins/aks-desktop/package-lock.json: Generated file
  • Files reviewed: 0/1 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread plugins/aks-desktop/package-lock.json
Comment thread plugins/aks-desktop/package-lock.json Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Regenerate the lockfile with SHA-512 integrity values and update the third-party notice.

Review details

Files not reviewed (1)

  • plugins/aks-desktop/package-lock.json: Generated file

Suppressed comments (2)

plugins/aks-desktop/package-lock.json:148

  • This update rewrites the lockfile's tarball integrity from SHA-512 to SHA-1 for this unchanged package, and the same downgrade is repeated across many dependency entries. That weakens npm's supply-chain verification even though the repository's other lockfiles retain SHA-512; regenerate this lockfile with the SHA-512 dist.integrity values instead of accepting the SHA-1 records.
    plugins/aks-desktop/package.json:76
  • Pinning @azure/identity to 4.13.1 makes the checked-in third-party notice stale: NOTICE.md still advertises @azure/identity 4.12.0, and its MSAL entries also remain on the older transitive versions. Regenerate/update the notice output with this dependency change so the distributed license attribution matches the packages being shipped.
    "@azure/identity": "4.13.1",
  • Files reviewed: 1/2 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The lockfile weakens integrity verification and depends on an internal registry URL.

Get a fresh assessment by requesting another Copilot review.

Review details

Files not reviewed (1)

  • plugins/aks-desktop/package-lock.json: Generated file

Suppressed comments (1)

plugins/aks-desktop/package-lock.json:329

  • This lockfile update replaces the existing SHA-512 integrity for @azure/identity (and many other tarballs in the same diff) with SHA-1. That weakens npm's download verification and deviates from the repository's lockfile convention, where registry packages use SHA-512 (for example, plugins/plugin-catalog/package-lock.json:100-102). Regenerate the lockfile against the public registry so the updated entries retain SHA-512 integrity metadata.
  • Files reviewed: 1/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

"version": "3.2.4",
"resolved": "https://registry.npmjs.org/@vitest/mocker/-/mocker-3.2.4.tgz",
"integrity": "sha512-46ryTE9RZO/rfDd7pEqFl7etuyzekzEhUbTW3BvmeO/BcCMEgq59BKhek3dXDWgAj4oMK6OZi+vRr1wPW6qjEQ==",
"resolved": "https://ms-feed-25.pkgs.visualstudio.com/1es-public/_packaging/npm-public/npm/registry/@vitest/mocker/-/mocker-3.2.4.tgz",
@skoeva
evangelos (skoeva) marked this pull request as draft September 16, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants