Conversation
FumingZhang
requested review from
NoriZC,
teresaritorto and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
northtyphoon,
terencet-dev,
yonzhan and
zhoxing-ms
microsoft-github-policy-service
bot
added
Auto-Assign
Member
Author
|
Queued live test to validate the change, test passed!
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens az aks check-acr against command injection and path/quoting issues by changing how kubectl version is invoked, aligning it with the safer kubectl run invocation style already used in the same function.
Changes:
- Replace a string-based
kubectl version ...shell command with an argv list (shell=False) to prevent command injection via temp-path interpolation. - Improve cross-platform correctness (notably Windows paths with spaces) by avoiding shell parsing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
FumingZhang
force-pushed
the
fuming/aks-check-acr-0409
branch
from
ab29784 to
4cc9175
Compare
yanzhudd
approved these changes
Apr 10, 2026
yanzhudd
changed the title
az aks check-acr: Fix command injection via unquoted tempfile path in subprocess callaz aks check-acr: Fix command injection via unquoted tempfile path in subprocess call
Contributor
|
I just updated the tile from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks check-acrDescription
The
aks_check_acr()function constructs a shell command using an f-string that interpolatesbrowse_path(fromtempfile.mkstemp()) and passes it tosubprocess.Popen(..., shell=True). This is vulnerable to command injection whenTMPDIR/TMP/TEMPcontains shell metacharacters, and breaks on Windows when the user's path contains spaces (e.g.C:\Users\John Smith\...).Convert the string-based shell command to a safe argument list with
shell=False(the default), consistent with the existingkubectl runcall later in the same function.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.