{Branch Management} Merge release back to dev#33218
Conversation
naga-nandyala
requested review from
DanielMicrosoft,
ReaNAiveD,
bebound,
jiasli,
necusjz and
yonzhan
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull request overview
This PR merges the release branch back into dev and includes updates to NetApp Files breaking-change registrations, affecting how deprecation guidance is surfaced to CLI users.
Changes:
- Removed deprecation registrations for
--default-group-quotaand--default-user-quotaonnetappfiles volume {create,update}. - Updated deprecation
redirectstrings for severalnetappfiles volume {create,update}arguments to point to the quota-rule command group (now without theazprefix).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| register_argument_deprecate('netappfiles volume create', '--is-default-quota-enabled', | ||
| redirect='command group az netappfiles volume quota-rule') | ||
| redirect='netappfiles volume quota-rule') | ||
| register_argument_deprecate('netappfiles volume update', '--is-default-quota-enabled', | ||
| redirect='command group az netappfiles volume quota-rule') | ||
| redirect='netappfiles volume quota-rule') | ||
| register_argument_deprecate('netappfiles volume create', '--default-group-quota-in-ki-bs', | ||
| redirect='command group az netappfiles volume quota-rule') | ||
| redirect='netappfiles volume quota-rule') |
There was a problem hiding this comment.
The redirect text here is shown verbatim in the deprecation warning ("Use '' instead"). Using netappfiles volume quota-rule omits the az prefix, so copy/pasting the suggestion won’t run as a command. Consider changing redirect to the full command, e.g. az netappfiles volume quota-rule (or similar) to make the guidance executable.
| register_argument_deprecate('netappfiles volume create', '--default-group-quota-in-ki-bs', | ||
| redirect='command group az netappfiles volume quota-rule') | ||
| redirect='netappfiles volume quota-rule') | ||
| register_argument_deprecate('netappfiles volume update', '--default-group-quota-in-ki-bs', | ||
| redirect='command group az netappfiles volume quota-rule') | ||
| redirect='netappfiles volume quota-rule') | ||
| register_argument_deprecate('netappfiles volume create', '--default-user-quota-in-ki-bs', | ||
| redirect='command group az netappfiles volume quota-rule') | ||
| redirect='netappfiles volume quota-rule') | ||
| register_argument_deprecate('netappfiles volume update', '--default-user-quota-in-ki-bs', | ||
| redirect='command group az netappfiles volume quota-rule') | ||
| redirect='netappfiles volume quota-rule') |
There was a problem hiding this comment.
--default-group-quota and --default-user-quota are still exposed as option aliases for volume create/update (see .../netappfiles/volume/_create.py and _update.py where options include both --default-*-quota and --default-*-quota-in-ki-bs). Removing the explicit deprecations for the non--in-ki-bs aliases means those aliases are no longer directly marked as deprecated (and the warning/help may only reflect the -in-ki-bs variant). If both aliases are intended to be deprecated in favor of netappfiles volume quota-rule, please re-add the deprecation registrations for --default-group-quota and --default-user-quota as well (or adjust the implementation so all aliases are tagged consistently).
Purpose
Merge
releaseback todevto maintain commit history consistency after hotfix PR #33211.Process
Do NOT squash merge. Follow the documented hotfix process:
releasetodevgit checkout dev && git pull origin devgit merge origin/release --no-ff -m "{Branch Management} Merge release back to dev"git push origin devContext
release(squash-merged)mainwas fast-forwarded to matchrelease(commite5d7420c3c)releaseintodevdevvia PR {NetAppFiles} Remove duplicate breaking announcement #33141