Skip to content

{Service Connector} az containerapp connection create: Block command as Service Connector (preview) on Azure Container Apps has been retired #33723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
khkh-ms wants to merge 1 commit into
base: dev
Choose a base branch
from
+20 −0
Open

{Service Connector} az containerapp connection create: Block command as Service Connector (preview) on Azure Container Apps has been retired #33723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/azure-cli/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,10 @@ Release History

* `az role deny-assignment create/delete`: Add new commands (#33109)

**Service Connector**

* `az containerapp connection create`: Block the command as Service Connector (preview) on Azure Container Apps has been retired (#38660284)

**SSH**

* `az ssh`: Restore explicit failure for unsupported managed identity and Cloud Shell SSH cert flows (#33534)
Expand Down
16 changes: 16 additions & 0 deletions src/azure-cli/azure/cli/command_modules/serviceconnector/_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,18 @@ def get_target_resource_name(cmd):
return target


def block_retired_containerapp_connection_create(cmd):
'''Block creating new Service Connector connections on Azure Container Apps.
Service Connector (preview) on Azure Container Apps has been retired.
See https://github.com/microsoft/azure-container-apps/issues/1566
'''
if 'create' in cmd.name and get_source_resource_name(cmd) == RESOURCE.ContainerApp:
raise ValidationError(
"Service Connector (preview) on Azure Container Apps has been retired. "
"'az containerapp connection create' is no longer supported. "
"For more information, see https://github.com/microsoft/azure-container-apps/issues/1566.")
Comment on lines +86 to +90
Comment on lines +86 to +90


def get_resource_type_by_id(resource_id):
'''Get source or target resource type by resource id
'''
Expand Down Expand Up @@ -930,6 +942,8 @@ def _validate_and_apply(validate, apply):
def validate_params(cmd, namespace):
'''Validate command parameters
'''
block_retired_containerapp_connection_create(cmd)

Comment on lines +945 to +946
def _validate_and_apply(validate, apply):
missing_args = validate(cmd, namespace)
if missing_args:
Expand Down Expand Up @@ -961,6 +975,8 @@ def _validate_and_apply(validate, apply):


def validate_kafka_params(cmd, namespace):
block_retired_containerapp_connection_create(cmd)

def _validate_and_apply(validate, apply):
missing_args = validate(cmd, namespace)
if missing_args:
Expand Down
Loading