Skip to content

feat(acr): surface x-ms-warning header on PE connection delete #33724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yushuliang0214 wants to merge 1 commit into
base: dev
Choose a base branch
from
+14 −2
Open

feat(acr): surface x-ms-warning header on PE connection delete #33724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/azure-cli/azure/cli/command_modules/acr/private_endpoint_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,12 @@
# Licensed under the MIT License. See License.txt in the project root for license information.
# --------------------------------------------------------------------------------------------

from knack.log import get_logger

from ._utils import get_resource_group_name_by_registry_name

logger = get_logger(__name__)


def _update_private_endpoint_connection_status(cmd, client, resource_group_name, registry_name,
private_endpoint_connection_name, is_approved=True, description=None):
Expand Down Expand Up @@ -54,8 +58,16 @@ def delete(cmd, client, registry_name, private_endpoint_connection_name, resourc

resource_group_name = get_resource_group_name_by_registry_name(cmd.cli_ctx, registry_name, resource_group_name)

return client.begin_delete(resource_group_name=resource_group_name, registry_name=registry_name,
private_endpoint_connection_name=private_endpoint_connection_name)
poller = client.begin_delete(resource_group_name=resource_group_name, registry_name=registry_name,
private_endpoint_connection_name=private_endpoint_connection_name)

# Surface server-side warning (e.g. PE connection not found, returned 204)
initial_response = poller.polling_method()._initial_response
warning = initial_response.http_response.headers.get("x-ms-warning")
Comment on lines +64 to +66
if warning:
logger.warning(warning)
Comment on lines +64 to +68

return poller


# cannot redefine list as it is a builtin function
Expand Down
Loading