[AKS] Fix AKS rollback auto-upgrade channel warning#33748
Open
InduSridhar wants to merge 1 commit into
Open
Conversation
️✔️AzureCLI-FullTest
|
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
Bot
requested review from
elvazhu521,
yanzhudd and
yonzhan
July 17, 2026 21:52
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a false warning in az aks nodepool rollback that incorrectly reported auto-upgrade as enabled when AKS SDK upgrade channel values are provided as string-enum types. It normalizes enum values before comparison so disabled channels like NONE are correctly treated as disabled.
Changes:
- Normalize
upgrade_channel/node_os_upgrade_channelby preferring an enum’s.valuewhen present before evaluating enabled/disabled state. - Update the rollback warning to display the normalized channel values.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
AKS |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
VeryEarly
changed the title
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
VeryEarly
approved these changes
Jul 19, 2026
VeryEarly
approved these changes
Jul 19, 2026
3 tasks
FumingZhang
changed the title
FumingZhang
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks nodepool rollbackDescription
Fixes a false AKS rollback warning when auto-upgrade channels are disabled. The SDK channel values are string enums;
str(NodeOSUpgradeChannel.NONE)returnsNodeOSUpgradeChannel.NONE, so comparingstr(enum).lower()withnoneincorrectly treats disabled channels as enabled.This change compares the enum
.valuewhen present before deciding whetherupgradeChannelornodeOSUpgradeChannelis enabled.Testing Guide
python3 -m py_compile src/azure-cli/azure/cli/command_modules/acs/custom.pyUpgradeChannel.NONEandNodeOSUpgradeChannel.NONE.History Notes
[AKS]
az aks nodepool rollback: Fix false auto-upgrade warning when upgrade channels are disabled.