fix: propagate context in remote build upload and log streaming#6922
Open
spboyer wants to merge 1 commit intoAzure:mainfrom
Open
fix: propagate context in remote build upload and log streaming#6922spboyer wants to merge 1 commit intoAzure:mainfrom
spboyer wants to merge 1 commit intoAzure:mainfrom
Conversation
- UploadBuildSource: use caller's ctx instead of context.Background() so blob upload respects cancellation (Ctrl+C) - streamLogs: replace bare time.Sleep with select on ctx.Done() so log polling responds to cancellation promptly Addresses finding 17 from Azure#6886 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
spboyer
requested review from
JeffreyCA,
hemarina,
rajeshkamal5050,
tg-msft and
weikanglim
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses context propagation issues in remote Azure Container Registry build operations to ensure cancellation signals (Ctrl+C) are properly respected. This is part of a broader performance review audit (Finding 17 from #6886).
Changes:
- Changed blob upload to use caller's context instead of
context.Background()so cancellation stops the upload immediately - Replaced bare
time.Sleep()with context-awareselectstatement in log polling loop to respond to cancellation within 1 second
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
vhvb1989
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propagate caller context in remote ACR build operations so cancellation (Ctrl+C) is respected.
Closes: #6921
Parent: #6886 (Performance Review Audit -- Finding 17)
Changes
pkg/containerregistry/remote_build.go:UploadBuildSource: ChangedblobClient.UploadFile(context.Background(), ...)toblobClient.UploadFile(ctx, ...)so blob upload respects cancellationstreamLogs: Replacedtime.Sleep(1 * time.Second)withselect { case <-ctx.Done(): return ctx.Err() case <-time.After(1 * time.Second): }so log polling responds to Ctrl+C promptlyTesting
go buildclean