Skip to content

Comments

recordings#45318

Open
howieleung wants to merge 2 commits intomainfrom
howie/recording-4
Open

recordings#45318
howieleung wants to merge 2 commits intomainfrom
howie/recording-4

Conversation

@howieleung
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates test recordings and adds comprehensive test coverage for resource management samples (connections, files, deployments, and datasets) in the azure-ai-projects SDK. The changes also improve dataset samples by making the CONNECTION_NAME environment variable optional with automatic fallback to default Azure Storage connections.

Changes:

  • Added four new test methods (connections, files, deployments, datasets) for both sync and async sample execution with LLM-based validation using resource_management_instructions
  • Enhanced dataset samples to automatically resolve default Azure Storage connections when CONNECTION_NAME is not provided
  • Added sanitizers for GitHub personal access tokens and improved SAS URI sanitization in test recordings
  • Removed "sample_agent_openapi.py" from the skip list to enable testing

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/ai/azure-ai-projects/tests/samples/test_samples_helpers.py Added resource_management_instructions for validating resource-focused sample output
sdk/ai/azure-ai-projects/tests/samples/test_samples_async.py Added async test methods for connections, files, deployments, and datasets samples
sdk/ai/azure-ai-projects/tests/samples/test_samples.py Added sync test methods for connections, files, deployments, and datasets samples; removed "sample_agent_openapi.py" from skip list
sdk/ai/azure-ai-projects/tests/conftest.py Added GitHub PAT sanitizer and improved SAS URI sanitization with full URL format
sdk/ai/azure-ai-projects/samples/datasets/sample_datasets_download.py Made CONNECTION_NAME optional, added get_default() fallback, improved output messages
sdk/ai/azure-ai-projects/samples/datasets/sample_datasets_async.py Made CONNECTION_NAME optional, added get_default() fallback with comprehensive error handling
sdk/ai/azure-ai-projects/samples/datasets/sample_datasets.py Made CONNECTION_NAME optional, added get_default() fallback with comprehensive error handling
sdk/ai/azure-ai-projects/assets.json Updated test recording tag reference
Comments suppressed due to low confidence (1)

sdk/ai/azure-ai-projects/samples/datasets/sample_datasets_async.py:23

  • There is inconsistent indentation in the documentation. Line 23 has an extra leading space before "2)" that should be removed to match the formatting of other numbered items in the list.
     2) CONNECTION_NAME - Optional. The name of the Azure Storage Account connection to use for uploading files.

@howieleung howieleung enabled auto-merge (squash) February 24, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants