Update Validation for Autoentities#3152
Merged
RubenCerna2079 merged 51 commits intomainfrom Mar 7, 2026
Merged
Conversation
RubenCerna2079
changed the title
RubenCerna2079
requested review from
Alekhya-Polavarapu,
Aniruddh25,
JerryNixon,
aaronburtle,
anushakolan,
rusamant,
sourabh1007,
souvikghosh04,
stuartpa and
vadeveka
as code owners
RubenCerna2079
force-pushed
the
dev/rubencerna/update-validation-autoentities
branch
from
7445062 to
5a0b722
Compare
Base automatically changed from
dev/rubencerna/create-inmemory-entities-from-autoentities
to
main
February 26, 2026 19:48
RubenCerna2079
dismissed
anushakolan’s stale review
The base branch was changed.
Aniruddh25
reviewed
Feb 26, 2026
Aniruddh25
reviewed
Feb 26, 2026
Aniruddh25
approved these changes
Mar 6, 2026
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Aniruddh25
approved these changes
Mar 7, 2026
Collaborator
|
@copilot, describe what this change is and edit the PR description to add that in the |
2 tasks
Contributor
|
@Aniruddh25 I've opened a new pull request, #3205, to work on those changes. Once the pull request is ready, I'll request review from you. |
github-project-automation
bot
moved this from Review In Progress
to Done
in Data API builder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
Startup.csbefore autoentity generation, so conflicts between manually defined and auto-generated entities were never caught.What is this change?
Validation reordered:
ValidatePermissionsInConfigandValidateEntityConfigurationremoved fromStartup.cs; both now execute insideSqlMetadataProvider.InitializeAsync()afterGenerateAutoentitiesIntoEntities()completes, ensuring the full entity set (manual + auto-generated) is validated together.New
ValidateEntityAndAutoentityConfigurationsmethod onRuntimeConfigValidator: consolidates REST/GraphQL path uniqueness, duplicate query/mutation detection, and permissions validation — runs in development mode only, consistent with prior behavior.RuntimeConfigValidatorinjected intoSqlMetadataProvider(and subclassesMsSqlMetadataProvider,PostgreSqlMetadataProvider,MySqlMetadataProvider) to enable calling the new method at the correct point in the init sequence.dab validateflow:ValidateEntitiesMetadatanow passes the validator into metadata provider initialization, sodab validatealso validates entity/autoentity configurations post-generation.CosmosDB:
ValidateEntityAndAutoentityConfigurationsadded toCosmosSqlMetadataProvider.InitializeAsync()for consistency.How was this tested?