test: add test harness, workspace validation, and integration tests#9
Merged
digimaun merged 5 commits intoAzure:mainfrom Apr 15, 2026
Merged
Conversation
…otations Tests: - Properties deep merge preserves sibling keys (overlays + inheritance) - Three-level inheritance preserves deep properties from all ancestors - enableSecretSync truthy/falsy condition evaluation - Missing intermediate property path in conditions - Deep nested output chaining (3+ levels) and missing mid-path - Malformed/truncated JSON stdout handled gracefully - All-steps-skipped manifest completes successfully - Duplicate step names detected by validation Bug fix: - Duplicate step names now produce a validation error (previously silent) Code quality: - Add missing type annotations across cli.py, orchestrator.py, models.py - Log proxy kill failures instead of silently swallowing (executor.py)
…nd chaining - All manifests pass orchestrator validation - Site inheritance resolves with complete deployOptions - Parameter chaining files reference valid steps and outputs - Conditional step properties exist in base-site.yaml
…arness Add site-agnostic integration test framework that deploys real manifests against Azure and asserts orchestrator outputs across all matched sites. Framework: - tests/integration/conftest.py: session-scoped deploy fixtures, site overlay generation from SITE_OVERRIDES, graceful skip when unconfigured - tests/integration/helpers/assertions.py: find_step, assert_step_succeeded, assert_output_exists with ARM output unwrapping Manifest tests: - test_aio_install_manifest.py: step outputs, conditional gating, idempotency - test_secretsync_manifest.py: resolve-aio outputs, SPC/MI/KV creation, idempotency - test_opc_ua_solution_manifest.py: deployment, conditionals, idempotency CI workflows: - .github/workflows/integration-test.yaml (GHA) - .pipelines/integration-test.yaml (ADO) - On-demand dispatch with manifest, skip-cleanup, and selector inputs
…cript Replace three copies of dot-notation expansion logic with a single reusable script (scripts/generate-site-overrides.py). - Supports stdin, --from-env, and --file input modes - Validates site names against path traversal (^[a-zA-Z0-9_-]+$) - Uses yaml.safe_dump (fixes yaml.dump in test conftest) - GHA and ADO deploy workflows now pipe to the script - Integration test conftest calls the script via subprocess - Platform-specific log masking remains in workflow YAML
digimaun
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
digimaun
force-pushed
the
test_harness_and_coverage
branch
2 times, most recently
from
bb7fa48 to
2b38d6f
Compare
digimaun
force-pushed
the
test_harness_and_coverage
branch
from
2b38d6f to
eec03dd
Compare
shkalavala
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add three layers of testing and consolidate CI overlay generation.
Engine unit tests:
Workspace content tests (tests/workspace/):
Integration test framework (tests/integration/):
Shared overlay generation (scripts/generate-site-overrides.py):