Skip to content

[Automated][azure-resource-manager] Update ARM documentation: fix deprecated APIs, doc comments, rule titles, and broken links#4353

Merged
tadelesh merged 10 commits into
mainfrom
docs/update-arm-documentation-da9333c50271e2a1
May 12, 2026
Merged

[Automated][azure-resource-manager] Update ARM documentation: fix deprecated APIs, doc comments, rule titles, and broken links#4353
tadelesh merged 10 commits into
mainfrom
docs/update-arm-documentation-da9333c50271e2a1

Conversation

@tadelesh
Copy link
Copy Markdown
Member

@tadelesh tadelesh commented Apr 29, 2026

Resolve: #4351

github-actions Bot and others added 4 commits April 29, 2026 05:03
- private-links-ref.tsp: Fix 'Properties of he private' -> 'Properties of the private'
- nsp-operations.tsp: Fix @dev 'GET' -> 'Perform an action on' for Action/ActionAsync (POST ops)
- arm.foundations.tsp: Remove ghost @template RequestBody tag not in op signature
- private-endpoints.tsp: Fix '{name PrivateEndpointConnection}' -> '{name} PrivateEndpointConnection'
- extension/operations.tsp: Fix truncated 'being rea' -> 'being read'

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…in ARM resource-type guide

- Replace deprecated envelope property spreads (ResourceSku → ResourceSkuProperty,
  EntityTag → EntityTagProperty, ResourcePlan → ResourcePlanProperty,
  ResourceKind → ResourceKindProperty, ManagedBy → ManagedByProperty)
- Replace deprecated ManagedIdentity spreads (ManagedServiceIdentity →
  ManagedServiceIdentityProperty, ManagedSystemAssignedIdentity →
  ManagedSystemAssignedIdentityProperty)
- Replace manual name definitions (@segment/@key/@visibility/@path/name)
  with ...ResourceNameParameter<ModelName> across all code examples
- Update decorator explanation bullets to describe ResourceNameParameter
- Fix broken sample links (DynaTrace, tenant, singleton, OperationTemplates)
- Fix typos: enevelope→envelope, SUpport→Support, defintion→definition
- Fix copy-paste error: 'Tenant resources' → 'Subscription-based resources'
  in the Subscription-based Resource section

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ate reference docs

- Fix rule doc frontmatter titles to match registered rule names (arm- prefix)
- Fix no-response-body.md title (was no-empty-model)
- Fix unsupported-type.md title and namespace
- Update step03/step05 to use ResourceNameParameter
- Fix add-common-types.md link to correct repository
- Regenerate reference docs (picked up TSP doc comment fixes)
- Format all changed files

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@microsoft-github-policy-service microsoft-github-policy-service Bot added eng lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library meta:website TypeSpec.io updates labels Apr 29, 2026
@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Apr 29, 2026

All changed packages have been documented.

  • @azure-tools/typespec-azure-resource-manager
Show changes

@azure-tools/typespec-azure-resource-manager - internal ✏️

Fix doc comment typos and inaccuracies in .tsp files

Copy link
Copy Markdown
Member Author

@tadelesh tadelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Resolve comments and check other changes to fix similar problem.

Comment thread website/src/content/docs/docs/howtos/ARM/resource-type.md Outdated
Comment thread website/src/content/docs/docs/howtos/ARM/resource-type.md Outdated
Comment thread website/src/content/docs/docs/howtos/ARM/resource-type.md Outdated
Comment thread website/src/content/docs/docs/howtos/ARM/resource-type.md Outdated
Comment thread website/src/content/docs/docs/howtos/ARM/resource-type.md Outdated
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 29, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@azure-tools/typespec-azure-resource-manager@4353

commit: b4ee06c

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 29, 2026

@copilot Resolve comments and check other changes to fix similar problem.

Done in 36d5207. Applied the explicit KeyName and SegmentName parameters to all ResourceNameParameter calls throughout the file, including the Extension Resource, Location-based Resource, Singleton Resource, and all the envelope property examples (Managed Identity, SKU, ETags, Plan, ResourceKind, ManagedBy).

@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Apr 29, 2026

You can try these changes here

🛝 Playground 🌐 Website

Copy link
Copy Markdown
Member Author

@tadelesh tadelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Check all the changes and make sure all resolved the comments I mentioned.

Comment thread website/src/content/docs/docs/howtos/ARM/resource-type.md Outdated
Comment thread website/src/content/docs/docs/howtos/ARM/resource-type.md Outdated
…iption text with code examples

Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/f07275e3-c768-4ee7-bc81-2d703f197f8d

Co-authored-by: tadelesh <1726438+tadelesh@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 29, 2026

@copilot Check all the changes and make sure all resolved the comments I mentioned.

Done in 39a0674. All cases reviewed: removed redundant explicit KeyName/SegmentName from Employee model examples (defaults already match), and updated all description text lines to consolidate with the updated code examples.

@tadelesh
Copy link
Copy Markdown
Member Author

@copilot Format the changes.

…ementResource example

Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/f289bb1a-020f-4798-82a4-01fb5813d67e

Co-authored-by: tadelesh <1726438+tadelesh@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 29, 2026

@copilot Format the changes.

Done in 100717b. Wrapped the long ResourceNameParameter<EmployeeAgreementResource, ...> template arguments in the TypeSpec code block to stay within the 100-character print width (the line was 125 chars).

Comment thread website/src/content/docs/docs/howtos/ARM/resource-type.md Outdated
Comment thread website/src/content/docs/docs/howtos/ARM/resource-type.md Outdated
Comment thread website/src/content/docs/docs/howtos/ARM/resource-type.md Outdated
Comment thread website/src/content/docs/docs/howtos/ARM/resource-type.md Outdated
Comment thread website/src/content/docs/docs/howtos/ARM/resource-type.md Outdated
Comment thread website/src/content/docs/docs/howtos/ARM/resource-type.md Outdated
Comment thread eng/scripts/doc-updater/knowledge/azure-resource-manager.md
@tadelesh
Copy link
Copy Markdown
Member Author

@copilot Merge main with resolving the conflict and resolve all current comments.

…le arm- prefixes

Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/1ec75ac6-d511-4561-b1ea-f24c6853eb3c

Co-authored-by: tadelesh <1726438+tadelesh@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented May 11, 2026

@copilot Merge main with resolving the conflict and resolve all current comments.

Done in 34e3b15. Main was already merged in 496c823 (no conflicts). Addressed all of @markcowl's review comments: renamed example models to drop the Resource suffix, simplified ResourceNameParameter<> calls to just the model name, reverted the rule doc title arm- prefixes to match the markdown filenames, and added an anti-pattern note about the Resource suffix to the ARM knowledge base.

@tadelesh
Copy link
Copy Markdown
Member Author

@copilot resolve the merge conflicts in this pull request

…entation-da9333c50271e2a1

# Conflicts:
#	website/src/content/docs/docs/libraries/azure-resource-manager/rules/delete-operation-response-codes.md
#	website/src/content/docs/docs/libraries/azure-resource-manager/rules/post-operation-response-codes.md
#	website/src/content/docs/docs/libraries/azure-resource-manager/rules/put-operation-response-codes.md
#	website/src/content/docs/docs/libraries/azure-resource-manager/rules/resource-name-pattern.md
#	website/src/content/docs/docs/libraries/azure-resource-manager/rules/unsupported-type.md

Co-authored-by: tadelesh <1726438+tadelesh@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented May 11, 2026

@copilot resolve the merge conflicts in this pull request

Done in b4ee06c. Merged origin/main and resolved conflicts in 5 ARM rule doc files (delete-/post-/put-operation-response-codes.md, resource-name-pattern.md, unsupported-type.md) — kept the frontmatter titles without the arm- prefix (per @markcowl's earlier review) and adopted main's title="Full name" code-fence formatting fix.

@tadelesh
Copy link
Copy Markdown
Member Author

@markcowl Could you review again?

@tadelesh tadelesh requested a review from markcowl May 11, 2026 05:17
@tadelesh tadelesh added this pull request to the merge queue May 12, 2026
Merged via the queue into main with commit 073d83d May 12, 2026
29 checks passed
@tadelesh tadelesh deleted the docs/update-arm-documentation-da9333c50271e2a1 branch May 12, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eng lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library meta:website TypeSpec.io updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Automated][azure-resource-manager] Update ARM documentation: fix deprecated APIs, doc comments, rule titles, and broken links

4 participants