Make @useFinalStateVia validation decorator-order independent for PUT operations

[Copilot]

@useFinalStateVia("original-uri") could incorrectly report invalid-final-state when @put was applied before/after it in a different order. The validator was effectively sensitive to decorator execution order instead of final operation shape.

• Post-decorator validation for @useFinalStateVia

  • Moved @useFinalStateVia validation into a decorator post-validation callback (onTargetFinish).
  • This evaluates HTTP verb/final-state constraints after all decorators on the target operation are applied, removing order dependency.

• Regression coverage for the reported ordering bug

  • Added a test for:
    • @put @useFinalStateVia("original-uri") on an LRO operation
  • Asserts no invalid-final-state diagnostic and confirms the override is stored as original-uri.

• Behavioral impact

  • No rule semantics changed; only validation timing changed to match final decorated operation metadata.

@pollingOperation(bar)
@test @put @useFinalStateVia("original-uri")
op foo(): {};

[timotheeguerin]

@copilot run formatter

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@azure-tools/typespec-azure-core@4394

commit: 0c4b635

[Copilot]

@copilot run formatter

Done in 93ef2cc. I ran the formatter and committed the resulting formatting-only update in use-final-state-via.test.ts.

[azure-sdk]

All changed packages have been documented.

• ✅ @azure-tools/typespec-azure-core

Show changes

@azure-tools/typespec-azure-core - fix ✏️

Make @useFinalStateVia validation decorator-order independent for PUT operations.

[azure-sdk]

You can try these changes here

🛝 Playground	🌐 Website

[timotheeguerin]

@copilot test are failing now

 FAIL   @azure-tools/typespec-autorest  test/lro.test.ts > typespec-autorest: Long-running Operations > Allows azure-async-operation override without headers for ARM PUT
AssertionError: Expected values to be strictly deep-equal:
+ actual - expected

  {
    'final-state-schema': '#/definitions/Widget',
+   'final-state-via': 'original-uri'
-   'final-state-via': 'azure-async-operation'
  }


- Expected
+ Received

  {
    "final-state-schema": "#/definitions/Widget",
-   "final-state-via": "azure-async-operation",
+   "final-state-via": "original-uri",
  }

 ❯ test/lro.test.ts:304:5
    302|       "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupNa…
    303|     deepStrictEqual(openapi.paths[itemPath].put?.["x-ms-long-running-o…
    304|     deepStrictEqual(openapi.paths[itemPath].put["x-ms-long-running-ope…
       |     ^
    305|       "final-state-via": "azure-async-operation",
    306|       "final-state-schema": "#/definitions/Widget",

i believe the validate does more than just validating we might need to split the data registration from the validaiton

[Copilot]

@copilot test are failing now

...

Fixed in 0c4b635. I restored the PUT-specific override registration in onTargetFinish (storedValue !== undefined || operation.verb === "put"), so @useFinalStateVia("azure-async-operation") is preserved for ARM PUT even when headers are missing. I also validated with targeted tests: typespec-autorest/test/lro.test.ts (the failing case) and typespec-azure-core/src/decorators/use-final-state-via.test.ts.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• telemetry.astro.build
  • Triggering command: /opt/hostedtoolcache/node/22.22.2/x64/bin/node node /home/REDACTED/work/typespec-azure/typespec-azure/core/website/node_modules/.bin/../astro/bin/astro.mjs build node enap�� run --local n/node import @typespecnode sh ents/reference node core�� build.json sh tp-server-js/node_modules/.bin/sh pm run lint-typenode sh tobuf/reference sh (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)