gantry: bound detached origin pulls by progress - #801
Open
Vaibhav Patel (vpatelsj) wants to merge 1 commit into
Open
Vaibhav Patel (vpatelsj) wants to merge 1 commit into
Vaibhav Patel (vpatelsj) wants to merge 1 commit into
Conversation
Vaibhav Patel (vpatelsj)
force-pushed
the
vapa/gantry-large-layer-02-detached-progress
branch
from
September 17, 2026 12:14
680532c to
a690706
Compare
Contributor
Author
|
E2E failure root cause: the initial implementation canceled the context passed to containerd ContentStore.Writer immediately after Writer returned. containerd retains that context for the remote writer stream, so later writes failed and no background ingest lease appeared. The updated commit keeps the context alive through write and commit and adds TestRunOriginPullKeepsWriterContextAlive. |
Julien Stroheker (julienstroheker)
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the five-minute size formula and 30-minute absolute detached-pull budget with a reset-on-read response-body progress watchdog. Add
origin_pull_progress_timeoutwith a five-minute default and explicit zero-to-disable semantics through YAML, environment, flags, and the shipped ConfigMap. Keep the containerd remote writer on the detached context for its full write and commit lifetime. This is one commit.Scope
Excludes Range support, partial-ingest resume, and separate writer/commit timeout policy.
Validation
go test ./internal/gantry/config ./cmd/gantry -count=1make gantry-manifestsStack
2/6. Depends on #800. Next layer: #802.