Skip to content

Remove deleted gradle API used by buildsystem plugin, Fixes AB#3689387#444

Open
ridam-arora wants to merge 2 commits into
masterfrom
ridamarora/upgradebuildsystem
Open

Remove deleted gradle API used by buildsystem plugin, Fixes AB#3689387#444
ridam-arora wants to merge 2 commits into
masterfrom
ridamarora/upgradebuildsystem

Conversation

@ridam-arora

@ridam-arora ridam-arora commented Jul 9, 2026

Copy link
Copy Markdown

AB#3689387

Changes the gradle API used by this plugin to set the sourceCompatibility and targetCompatibility properties. the API JavaPluginConvention has been deleted in gradle 9+

@ridam-arora ridam-arora requested a review from a team as a code owner July 9, 2026 20:14
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

@ridam-arora ridam-arora changed the title Remove deleted gradle API used by buildsystem plugin Remove deleted gradle API used by buildsystem plugin AB #3689387 Jul 9, 2026
@ridam-arora ridam-arora changed the title Remove deleted gradle API used by buildsystem plugin AB #3689387 Remove deleted gradle API used by buildsystem plugin AB#3689387 Jul 9, 2026
@ridam-arora

Copy link
Copy Markdown
Author

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

@ridam-arora ridam-arora closed this Jul 9, 2026
@ridam-arora ridam-arora reopened this Jul 9, 2026
@ridam-arora

Copy link
Copy Markdown
Author

@ridam-arora please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

@ridam-arora ridam-arora changed the title Remove deleted gradle API used by buildsystem plugin AB#3689387 Remove deleted gradle API used by buildsystem plugin, Fixes AB#3689387 Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

✅ Work item link check complete. Description contains link AB#3689387 to an Azure Boards work item.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

❌ Invalid work item number: AB#3689387

Changes. Work item number must be a valid integer.

Click here to learn more.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the internal plugins/buildsystem Gradle plugin to avoid Gradle 9+ removed APIs by switching Java compatibility configuration to JavaPluginExtension, and adds internal feed publishing configuration for the plugin artifact.

Changes:

  • Replace legacy Java compatibility configuration with JavaPluginExtension#setSourceCompatibility/#setTargetCompatibility.
  • Add a changelog entry for the Gradle API migration.
  • Bump plugin version and add publishing repository config targeting the NewAndroid Azure Artifacts feed.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
plugins/buildsystem/src/main/java/com/microsoft/identity/buildsystem/BuildPlugin.java Switch Java source/target compatibility configuration to JavaPluginExtension (Gradle 9+ compatible).
plugins/buildsystem/changelog Add release notes entry documenting removal of deleted Gradle APIs.
plugins/buildsystem/build.gradle Bump plugin version and add internal Azure Artifacts publishing repository configuration.


group 'com.microsoft.identity'
version '0.2.5'
version '0.2.6-dev'
Comment thread plugins/buildsystem/build.gradle Outdated
Comment on lines +65 to +66
username System.getenv("ENV_VSTS_MVN_CRED_USERNAME") != null ? System.getenv("ENV_VSTS_MVN_CRED_USERNAME") : project.findProperty("vstsUsername")
password System.getenv("ENV_VSTS_MVN_CRED_ACCESSTOKEN") != null ? System.getenv("ENV_VSTS_MVN_CRED_ACCESSTOKEN") : project.findProperty("vstsMavenAccessToken")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants