[fix] 애플 로그인 시 이름 스킵#144
Merged
Conversation
📝 WalkthroughWalkthrough이 PR은 가입 과정에서 사용자 이름을 미리 가져오는 기능을 추가합니다. Possibly related issues
추가 피드백React/TypeScript 컨벤션 관점:
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/pages/Auth/SignUp/StudentIdStep.tsx (1)
12-12: 로딩/에러 상태 UX 개선 고려
isPending동안 버튼이 비활성화되지만, 사용자에게 로딩 중임을 시각적으로 알려주는 것이 좋습니다.isError상태도 활용할 수 있습니다.- const { data: prefill, isPending } = useSignupPrefill(); + const { data: prefill, isPending, isError } = useSignupPrefill();🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/pages/Auth/SignUp/StudentIdStep.tsx` at line 12, The signup prefill hook returns isPending (and likely isError); update the StudentIdStep UI to surface these states: when useSignupPrefill().isPending is true show a visual loading indicator (e.g., spinner/LoadingButton state) on the primary action button and keep it disabled, and when useSignupPrefill().isError is true show a concise inline error message with an affordance to retry (e.g., a retry button or re-run the prefill call) so users know why prefill failed; locate the usage of useSignupPrefill, prefill, isPending and add the loading/error UI and retry handler accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/pages/Auth/SignUp/StudentIdStep.tsx`:
- Line 12: The signup prefill hook returns isPending (and likely isError);
update the StudentIdStep UI to surface these states: when
useSignupPrefill().isPending is true show a visual loading indicator (e.g.,
spinner/LoadingButton state) on the primary action button and keep it disabled,
and when useSignupPrefill().isError is true show a concise inline error message
with an affordance to retry (e.g., a retry button or re-run the prefill call) so
users know why prefill failed; locate the usage of useSignupPrefill, prefill,
isPending and add the loading/error UI and retry handler accordingly.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
src/apis/auth/index.tssrc/pages/Auth/SignUp/StudentIdStep.tsxsrc/pages/Auth/SignUp/hooks/useSignupPrefill.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
릴리스 노트