Adding text to pdf file#19
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds support for inserting styled text into PDFs and returns available font lists in the PDF service.
- Extends ReadFields to include available font keys and updates IPdfService, controller, and response model.
- Implements FontsHelper to discover registered, document-embedded, and resource folder fonts.
- Adds text styling (size, color, alignment, bold/italic/underline) in Fill and corresponding tests.
Reviewed Changes
Copilot reviewed 13 out of 28 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| API/appsettings.json | Added Resources:Fonts section and fixed trailing comma |
| API/Services/ITextPdfService/PdfService.cs | Updated ReadFields/Fill to support fonts and text styling; added FontsHelper |
| API/Services/IPdfService.cs | Changed ReadFields signature to return font list |
| API/Program.cs | Removed unused using Microsoft.OpenApi.Models; |
| API/Models/Responses/FieldsResponse.cs | Added Fonts property |
| API/Models/Requests/FillRequest.cs | Added TextStyle, FontStyle, and alignment enums |
| API/Converters/FieldValueJsonConverter.cs | Extended converter to handle int, double, bool |
| API/Converters/EnumJsonConverter.cs | Introduced generic enum JSON converter |
| API/Controllers/PdfController.cs | Adapted ReadFields to include fonts in response |
| API.Tests/... | Added functional tests for fonts and text insertion; updated converter tests |
Comments suppressed due to low confidence (1)
API/Services/ITextPdfService/PdfService.cs:308
- FontsHelper scans resource directories and the document for every instance. Consider caching font discovery globally or reusing a singleton helper to avoid repeated I/O and improve performance.
class FontsHelper
artemkdr
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding text to pdf file + tests + some bug fixed