Added admin files to add zscores and numSubjects to the database. Als…#35
Open
11rohans wants to merge 1 commit intoBIDS-collaborative:BIDS-collaborativefrom
Open
Added admin files to add zscores and numSubjects to the database. Als…#3511rohans wants to merge 1 commit intoBIDS-collaborative:BIDS-collaborativefrom
11rohans wants to merge 1 commit intoBIDS-collaborative:BIDS-collaborativefrom
Conversation
…o updated interface to show a column for zScores
Member
|
This looks great! @11rohans one suggestion I have would be to separate out commits where you squash whitespace (which is great!) from commits where you do substantive work. If you look at the "Files Changed" tab you'll see that your changes are way down below a bunch of deleted whitespace. @r03ert0 Do you want to have a look at this? Given that it's a database change, i would like your approval (and make sure you can run this). If not you, then at least @jbpoline? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…o updated interface to show a column for zScores