Skip to content

Ensure NO Qt signal is connected to another signal#202

Merged
rocco8773 merged 17 commits into
mainfrom
ensure_no_signal_connected_to_signal
Jun 24, 2026
Merged

Ensure NO Qt signal is connected to another signal#202
rocco8773 merged 17 commits into
mainfrom
ensure_no_signal_connected_to_signal

Conversation

@rocco8773

@rocco8773 rocco8773 commented Jun 24, 2026

Copy link
Copy Markdown
Member

Enforce Qt signals being only connected to slots.


AxisControlWidget

  • Created dedicated "slots" to be connected to the Motor SimpleSignal's
    • _actor_slot_connection_established (replaces _emit_connection_established)
    • _actor_slot_connection_lost (replaces _emit_connection_lost)
    • _actor_slot_movement_started (replaces _emit_movement_started)
    • _actor_slot_movement_finished (replaces _emit_movement_finished)
    • _actor_slot_status_changed
  • Renamed signal requestDispalyRefresh to refreshDisplay.
  • Created private signal _actorStatusChanged ... is meant to be triggered by the Motor SimpleSignal status_changed.
  • Created hanlde @Slot methods
    • _handle_movement_stopped which handles internal processes when a motor stops, and emits axisStatusChanged
    • _handlue_actor_status_changed which handles internal processes when the motor status changes, and emits axisStatusChanged.

DriveBaseController

  • Remove driveStatusChagned signal from being connected to AxisControlWidget.axisStatusChanged
  • Have update_all_axis_displays() emit AxisControlWidget.refreshDisplay instead of directly updating the axis display.
    • Have update_all_axis_displays() emit driveStatusChanged.
  • Create @Slot _handle_zero_all_btn_clicked to be triggered by the zero_all_btn, instead of emitting zeroDrive directly.

AxisConfigWidget

  • Create slot _actor_triggered_config_changed with is connected to the Motor SimpleSignal's connection_established and connection_lost. This "slot" will emit configChanged.

@rocco8773 rocco8773 merged commit 8fb0be4 into main Jun 24, 2026
17 checks passed
@rocco8773 rocco8773 deleted the ensure_no_signal_connected_to_signal branch June 24, 2026 03:43
@github-project-automation github-project-automation Bot moved this from Tasks to Done in BaPSF Motion Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant