Ensure NO Qt signal is connected to another signal#202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce
Qtsignals being only connected to slots.AxisControlWidgetMotorSimpleSignal's_actor_slot_connection_established(replaces_emit_connection_established)_actor_slot_connection_lost(replaces_emit_connection_lost)_actor_slot_movement_started(replaces_emit_movement_started)_actor_slot_movement_finished(replaces_emit_movement_finished)_actor_slot_status_changedrequestDispalyRefreshtorefreshDisplay._actorStatusChanged... is meant to be triggered by theMotorSimpleSignalstatus_changed.@Slotmethods_handle_movement_stoppedwhich handles internal processes when a motor stops, and emitsaxisStatusChanged_handlue_actor_status_changedwhich handles internal processes when the motor status changes, and emitsaxisStatusChanged.DriveBaseControllerdriveStatusChagnedsignal from being connected toAxisControlWidget.axisStatusChangedupdate_all_axis_displays()emitAxisControlWidget.refreshDisplayinstead of directly updating the axis display.update_all_axis_displays()emitdriveStatusChanged.@Slot_handle_zero_all_btn_clickedto be triggered by thezero_all_btn, instead of emittingzeroDrivedirectly.AxisConfigWidgetslot_actor_triggered_config_changedwith is connected to theMotorSimpleSignal'sconnection_establishedandconnection_lost. This "slot" will emitconfigChanged.