Skip to content

refactor(tui): retire Tab/Shift+Tab and bracket inspector bindings - #110

Merged
jkyberneees merged 1 commit into
mainfrom
fix/retire-tab-brackets
Sep 11, 2026
Merged

refactor(tui): retire Tab/Shift+Tab and bracket inspector bindings#110
jkyberneees merged 1 commit into
mainfrom
fix/retire-tab-brackets

Conversation

@jkyberneees

Copy link
Copy Markdown
Contributor

Summary

Retires the transcript inspector's Tab/Shift+Tab traversal and [/] tool-detail paging bindings, from code and docs (follow-up cleanup to the bindings standardization in #109).

  • Traversal while inspecting: / (was Tab/Shift+Tab)
  • Tool-detail paging: PgUp/PgDn (was [/]) — same keys the viewport already uses
  • Bare Tab, [, ] now always behave as plain input; a bare rune while inspecting returns focus to the composer
  • Updated: inspector footer (↑↓ next · ⏎ expand · Pg↑↓ page), paging label, F1 help card, README (binding table + "Inspecting tool responses" section), AGENTS.md
  • Untouched by design: AC-popup tab-accept, approval-card tab-expand, drawer ]/[ tab cycling

Behavior note

With Tab gone, keyboard-only inspector entry from the idle composer no longer exists — inspection arms by clicking a tool header / reasoning block (this was already the primary path). Flagging for visibility.

Testing

  • RED-first: retirement tests fail on main (tab moved inspector focus, footer advertised Tab next / [ ] page); empirically confirmed by adversarial review on a main worktree
  • 4 existing tests that pinned the old bindings updated to pin the arrow/PgUp-PgDn forms (traversal, backward traversal, paging clamp, bounded rendering)
  • Adversarial review findings fixed: stale README instructions section, stale code comment, vacuous paging test (now seeds a mid-list offset and covers both brackets + PgDn)
  • make fmt vet lint test green: vet clean, lint 0 issues, full -race suite across 8 packages

The transcript inspector drops its Tab/Shift+Tab traversal and [ ]
paging bindings: arrow keys (up/down) are the traversal form while
inspecting, and PgUp/PgDn page the expanded tool detail — the same keys
the viewport already uses, so bare Tab and [ ] always behave as plain
input. Footers, the paging label, the F1 help card, README, and
AGENTS.md are updated to the new grammar; tests that pinned the old
bindings now pin the arrows/PgUp-PgDn forms. The AC-popup tab-accept,
approval tab-expand, and drawer ]/[ tab cycling are untouched.
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
bodek be5eacc Commit Preview URL

Branch Preview URL
Sep 11 2026, 06:37 AM

@jkyberneees
jkyberneees merged commit 561ad48 into main Sep 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant