feat: split the agent by vendor#56
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the kcover-agent into two distinct flavors—a generic base image and a MetaX-specific image—using Go build tags (!metax and metax). The Helm chart and Makefile have been updated to support this new architecture, allowing users to select the agent flavor and conditionally mount MetaX-specific host resources. Additionally, configuration parsing has been modularized, and dependencies have been updated. Review feedback identifies an optimization opportunity in the MetaX detector's Start method, where an unused ticker causes unnecessary periodic wakeups and should be removed along with its associated interval field.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| } | ||
|
|
||
| func (d *detector) Start() error { | ||
| func (d *metaXDetector) Start() error { |
There was a problem hiding this comment.
In the Start method, there is a ticker initialized using d.interval that is completely unused except for a case <-ticker.C: continue statement in the select loop. This causes unnecessary periodic wakeups of the goroutine without performing any actual work, wasting CPU cycles.
Since the day2 checks are scheduled to run daily at Day2CheckTime using timer, the ticker and the interval field in metaXDetector can be safely removed.
No description provided.