fix(chart): render workload pod settings#59
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for custom pod labels, node selectors, affinity, and tolerations to both the agent daemonset and controller deployment Helm templates, along with corresponding verification tests in verify-helm.sh and updates to .dockerignore. The feedback suggests using the more idiomatic parenthesized (dict) instead of dict as a default value in the Helm templates to prevent potential parsing issues.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| app: {{ include "kcover.fullname" . }}-agent | ||
| template: | ||
| metadata: | ||
| {{- $podLabels := deepCopy (default dict .Values.agent.podLabels) }} |
There was a problem hiding this comment.
Using default dict is non-idiomatic in Helm templates and can be confusing or cause parsing issues with some IDEs/linters. It is highly recommended to use parenthesized (dict) to explicitly evaluate the function and return an empty dictionary.
{{- $podLabels := deepCopy (default (dict) .Values.agent.podLabels) }}| type: RollingUpdate | ||
| template: | ||
| metadata: | ||
| {{- $podLabels := deepCopy (default dict .Values.controller.podLabels) }} |
There was a problem hiding this comment.
Using default dict is non-idiomatic in Helm templates and can be confusing or cause parsing issues with some IDEs/linters. It is highly recommended to use parenthesized (dict) to explicitly evaluate the function and return an empty dictionary.
{{- $podLabels := deepCopy (default (dict) .Values.controller.podLabels) }}1 participant
No description provided.