Skip to content

refactor(settings): improve compile-time type safety for QR scanner quick tile #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Balajitechlabs wants to merge 1 commit into from
Closed

refactor(settings): improve compile-time type safety for QR scanner quick tile #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...chlabs/quickdash/features/settings/presentation/sections/SettingsFloatingWindowSection.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import android.net.Uri
import android.os.Build
import android.provider.Settings
import android.widget.Toast
import com.balajitechlabs.quickdash.core.quicktile.QrScannerTileService
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
Expand Down Expand Up @@ -250,10 +251,10 @@ fun SettingsFloatingWindowSection(
onClick = {
if (Build.VERSION.SDK_INT >= 33) {
try {
val manager = context.getSystemService(Context.STATUS_BAR_SERVICE) as StatusBarManager
val manager = context.getSystemService(StatusBarManager::class.java)
val componentName = ComponentName(
context,
"com.balajitechlabs.quickdash.core.quicktile.QrScannerTileService"
QrScannerTileService::class.java

@Balajitechlabs Balajitechlabs Sep 13, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] Type-safe class reference prevents R8/ProGuard obfuscation breakage.

Suggested change
QrScannerTileService::class.java
val componentName = ComponentName(
context,
QrScannerTileService::class.java
)

)
manager.requestAddTileService(
componentName,
Expand Down
Loading