Skip to content

perf(decode): pool rec buffer in unmarshalValue #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xe-nvdk merged 1 commit into from
Mar 3, 2026
Merged

perf(decode): pool rec buffer in unmarshalValue #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions decode_value.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,18 @@ import (
"errors"
"fmt"
"reflect"
"sync"

"github.com/vmihailenco/msgpack/v5/msgpcode"
)

var recBufPool = sync.Pool{
New: func() interface{} {
b := make([]byte, 0, 64)
return &b
},
}

var (
interfaceType = reflect.TypeOf((*interface{})(nil)).Elem()
stringType = reflect.TypeOf((*string)(nil)).Elem()
Expand Down Expand Up @@ -233,17 +241,29 @@ func decodeCustomValue(d *Decoder, v reflect.Value) error {
}

func unmarshalValue(d *Decoder, v reflect.Value) error {
var b []byte
bp := recBufPool.Get().(*[]byte)
*bp = (*bp)[:0]

d.rec = make([]byte, 0, 64)
d.rec = *bp
if err := d.Skip(); err != nil {
d.rec = nil
*bp = (*bp)[:0]
recBufPool.Put(bp)
return err
}
b = d.rec
b := d.rec
d.rec = nil

unmarshaler := v.Interface().(Unmarshaler)
return unmarshaler.UnmarshalMsgpack(b)
err := unmarshaler.UnmarshalMsgpack(b)

// Return buffer to pool; drop oversized buffers.
if cap(b) <= 4096 {
*bp = b
recBufPool.Put(bp)
}

return err
}

// unmarshalBinaryOrTextValue peeks at the wire format to choose between
Expand Down