Remove the submit tools and the solve and learn prompts - #191
Merged
Merged
Conversation
3 tasks done
yichao-liang
force-pushed
the
empiric-phased-cleanup
branch
from
September 28, 2026 00:08
31b3ab6 to
63c5dc6
Compare
The phased solve sessions delivered plans through submit_plan and submit_policy, whose capture gate re-ran each plan (repeat rollouts, physics and rule-parameter margins, a necessity check, a robot clearance probe) before accepting it. The continual arms never had these tools. This removes them together with: - the solve and learn prompt templates, their goldens and tests - the attempt deadline and the capture fields on the tool context - the standalone arm's particle override scope - the journal's strategy document and test-phase rollback helpers - the skills' contact_objects hook, which only the clearance probe read - 14 settings flags that lost their last reader The empiric configs stop setting the three removed flags they named; none of them changed behavior. Tool descriptions and probe docstrings the agent can read still mention submit_plan and are left for a separate change, since editing them changes the agent's prompts.
yichao-liang
force-pushed
the
empiric-submit-tools-cleanup
branch
from
September 28, 2026 06:00
a3b4c01 to
d7c9bac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #190 (base
empiric-phased-cleanup); review and merge after it.The phased solve sessions delivered plans through
submit_planandsubmit_policy.Their capture gate re-ran each plan before accepting it: repeat rollouts, physics and rule-parameter margins, a necessity check and a robot-clearance probe.
The continual arms never had these tools; they rehearse plans with the
simprobe insiderun_python.This removes the tools and what only they used: 79 files, about 8.7k lines.
Deleted:
tools/testing.py,tools/capture.py,tools/tasks.pyandtools/clearance.py;sketch_prompts.py,learn_prompts.py, thesolve_*andlearn_*templates, and their goldens and tests;ToolContext;contact_objectshook, which only the clearance probe read;agent_plan_validation_rule_param_marginandagent_plan_validation_physics_margin, which the no-uncertainty and real-to-sim arms only checked were off.Moved:
_policy_source_pathintotools/verdicts.py, andrender_physical_params_sectionintoplay_prompts.py.No benchmark arm changes behavior.
The rule-parameter ensemble used to be built when info-seeking or the margin gate was on; its only remaining reader is info-seeking, and every benchmark arm sets the two flags alike.
The empiric configs stop setting the three removed flags they named.
Left for a separate change: tool descriptions and probe docstrings that the agent can read still mention
submit_plan(tools/exploration.py,tools/synthesis.py, notices and docstrings inbelief_probe.py, theevaluate_trajectoryhelper).Editing them changes the agent's prompts, so that should be its own decision.
Test plan
🤖 Generated with Claude Code