Fold AgentModelFreeApproach and AgentSessionMixin into AgentBaseApproach - #194
Merged
Merged
Conversation
3 tasks done
AgentModelFreeApproach had become the base of every agent arm, the EMPIRIC line and the model-free arm alike, and its task solver only raised. AgentSessionMixin had that class as its only host. The two become one abstract base, AgentBaseApproach, which has no approach name of its own, so the unused agent_model_free name is gone. Behavior is unchanged: the arms inherit the same methods, the log directory is still created on first use, and checkpoints keep their format.
yichao-liang
changed the base branch from
empiric-prompt-submit-refs
to
master
September 28, 2026 07:01
yichao-liang
force-pushed
the
empiric-fold-model-free
branch
from
September 28, 2026 07:01
5df63e5 to
72ebca0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #192 (base
empiric-prompt-submit-refs); review and merge after it.AgentModelFreeApproachhad become the base of every agent arm:AgentSimLearningApproach(and through it EMPIRIC and its model-based baselines) andAgentContinualModelFreeApproach, the model-free arm.Its task solver only raised, and its name described neither role.
AgentSessionMixinhad that class as its only host.The two become one abstract base,
AgentBaseApproachinapproaches/agent_base_approach.py:get_name, so it cannot be created by name, and the unusedagent_model_freeapproach name is gone.Behavior is unchanged: every arm inherits the same methods,
_get_log_dirstill creates the directory, and checkpoints keep their format.Docs and comments that named the old classes are updated, including a few that still described the deleted Docker manager, agent explorers and phased learn hook.
Test plan
test_gather_timeout_returns_partialin shard 7, a timing flake independent of this change (reproduced and fixed in Wait for the fast rollout before timing gather's partial return #193).🤖 Generated with Claude Code