Skip to content

Fold AgentModelFreeApproach and AgentSessionMixin into AgentBaseApproach - #194

Merged
yichao-liang merged 1 commit into
masterfrom
empiric-fold-model-free
Sep 28, 2026
Merged

yichao-liang merged 1 commit into
masterfrom
empiric-fold-model-free

Conversation

@yichao-liang

Copy link
Copy Markdown
Collaborator

Summary

Stacked on #192 (base empiric-prompt-submit-refs); review and merge after it.

AgentModelFreeApproach had become the base of every agent arm: AgentSimLearningApproach (and through it EMPIRIC and its model-based baselines) and AgentContinualModelFreeApproach, the model-free arm.
Its task solver only raised, and its name described neither role.
AgentSessionMixin had that class as its only host.

The two become one abstract base, AgentBaseApproach in approaches/agent_base_approach.py:

  • the session machinery (tool-surface checks, session construction, queries) and the approach glue (option model, tool-context sync, checkpoints) live in one class;
  • it defines no get_name, so it cannot be created by name, and the unused agent_model_free approach name is gone.

Behavior is unchanged: every arm inherits the same methods, _get_log_dir still creates the directory, and checkpoints keep their format.
Docs and comments that named the old classes are updated, including a few that still described the deleted Docker manager, agent explorers and phased learn hook.

Test plan

🤖 Generated with Claude Code

AgentModelFreeApproach had become the base of every agent arm, the
EMPIRIC line and the model-free arm alike, and its task solver only
raised. AgentSessionMixin had that class as its only host. The two
become one abstract base, AgentBaseApproach, which has no approach name
of its own, so the unused agent_model_free name is gone.

Behavior is unchanged: the arms inherit the same methods, the log
directory is still created on first use, and checkpoints keep their
format.
@yichao-liang
yichao-liang changed the base branch from empiric-prompt-submit-refs to master September 28, 2026 07:01
@yichao-liang
yichao-liang force-pushed the empiric-fold-model-free branch from 5df63e5 to 72ebca0 Compare September 28, 2026 07:01
@yichao-liang
yichao-liang merged commit 88ea7bb into master Sep 28, 2026
14 checks passed
@yichao-liang
yichao-liang deleted the empiric-fold-model-free branch September 28, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant