Make the paper's Fan and Balloons scenes the defaults - #196
Merged
Merged
Conversation
Fan now defaults to the scene of the paper and its benchmark config: the exposed deck with the downhill ramp, inertial dynamics, no walls and a 3 x 3 grid, which also brings the wide camera. HISTORICAL_ARENA_FLAGS in pybullet_fan.py restores the historical uniform/maze arena, and the tests written for that arena now set it explicitly. Balloons draws its ceiling as an opaque red cap across the chute, the picture the paper figures used, in place of a translucent plate over the whole table. The ceiling is visual only, so no physics changes. scripts/paper_figures/render_run_videos.py renders a run's labelled video from its recorded states moved into the current scene layouts, as the figures do, for runs recorded before those layouts changed. The figure exporter now drops launch flags that the current code no longer defines, which broke restoring older runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/configs/empiric: the exposed deck with the downhill ramp, inertial dynamics, no walls and a 3 x 3 grid, which also brings the wide camera.HISTORICAL_ARENA_FLAGSinpybullet_fan.pyrestores the historical uniform/maze arena, and the tests written for that arena now set it explicitly.scripts/paper_figures/render_run_videos.pyrenders a run's labelled video from its recorded states, moved into the current scene layouts as the figures do. Replaying the actions of runs recorded before the layouts changed does not reproduce them in the current env. The project page uses it for the Balloons and Fan videos._load_run_confignow drops launch flags that the current code no longer defines; restoring older runs failed on them since the agent flags were removed.docs/RENDERING.mddocuments both.The committed paper-figure scenes are unchanged: re-exporting the Balloons scenes gives the same ceiling cap.
Test plan
HISTORICAL_ARENA_FLAGS(80 passed, the same 4 xfails as master).🤖 Generated with Claude Code