Feature: add configurable selection of vehicles on train(s) as a target#132
Feature: add configurable selection of vehicles on train(s) as a target#132Manticore-007 wants to merge 28 commits intoBasssiiie:mainfrom
Conversation
|
cool that you got the spin! why not implementing 'every n car on all trains' while you're at it? |
;-) |
export was a leftover which is unnecessary.
|
|
…Manticore-007/OpenRCT2-RideVehicleEditor into Specific-vehicles-on-all-trains
Specific vehicles on all trains
Manticore-007
changed the title
|
Sorry for the mess with the PR's, but I couldn't find where to merge my |
Basssiiie
left a comment
Basssiiie
left a comment
There was a problem hiding this comment.
Hey! Thank you for your contributions and time. 😄
I haven't tested it yet, but do have a few comments.
src/services/vehicleCopier.ts
Outdated
| { | ||
| settings: VehicleSettings; | ||
| targets: VehicleSpan[]; | ||
| sequence: number; |
There was a problem hiding this comment.
Isn't the targets array already meant to have the correct vehicles based on the sequence?
There was a problem hiding this comment.
As far as I was aware, the vehicle span modifies adjacent vehicles behind it, I need sequence to skip vehicles. Or am I misunderstanding?
There was a problem hiding this comment.
I've been playing around some more, but I really dislike the spacing of the train not working as expected with the suggestion you made. I have another option that does work, and that is extending the VehicleSpan tuple with a third element, for the sequence.
With this the spacing functionality can be maintained, I am certain a lot of players want this feature to be upholded in this new addition.
src/services/vehicleEditor.ts
Outdated
| * to their default values for that type. | ||
| */ | ||
| export function setRideType(vehicles: VehicleSpan[], type: RideType): void | ||
| export function setRideType(vehicles: VehicleSpan[], type: RideType, sequence: number): void |
There was a problem hiding this comment.
Same for these changes in this file. The vehicles array should already have be adapted to the sequence, no?
3 participants
Messing around with a Carnaval Festival-esque ride, took me a long time to modify each other vehicle to a reverser bogey by hand:
So that gave me the idea to add a feature where you can configure which vehicles on the train you want to modify.
2025-05-21.21-31-44.mp4
2025-05-21.22-03-36.mp4
(The multiplier works with the new spinners, I just forgot about it when recording this video)
Eventually I moved the option at the bottom of the "this train" options and renamed it to
Custom selection of vehicles on this trainto keep everything consistent and/or uniform.Todo: add this feature for all the trains on a ride.Already got it to work.