feat: rebase + measure via getBoundingClientRect + add roundingMode prop for sub-pixel rounding control - #1
Open
jainamdhirenshah-bpi wants to merge 21 commits into
Conversation
* Fix issue with unused import being emitted * Fix import
* Fix grid roles for accessbility * Add test for gridcell role
… to handle any downsream consequences.
Co-authored-by: Anton Dubrouski <anton.dubrouski@softnetix.io>
…ode` prop for sub-pixel rounding control
This ensures the AutoSizer will render properly even when browser zoom is <= 80%
jainamdhirenshah-bpi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm test) all passyarn run prettier).yarn run typecheck).--
As it stands right now the
AutoSizerhas an issue; any fractional heights/widths are rounded up. This means the child content is told it has more space to play with than the reality which can lead to overflow issues and the likes.This change rebases the react-virtualized repo to get the latest changes and also proposes a shift to using
getBoundingClientRectwhich consumes the fractional height/width correctly and then rounds it according to the newly exposedroundingModeprop. By default, for backwards compatibility it will useceilwhich rounds upwards.