feat: add parameter validation to cube(), cylinder(), sphere() (#108)#1957
Open
junhinhow wants to merge 1 commit intoBelfrySCAD:masterfrom
Open
feat: add parameter validation to cube(), cylinder(), sphere() (#108)#1957junhinhow wants to merge 1 commit intoBelfrySCAD:masterfrom
junhinhow wants to merge 1 commit intoBelfrySCAD:masterfrom
Conversation
These three fundamental modules had minimal parameter validation, causing cryptic errors when invalid values were passed. Added asserts: - cube(): size must be a non-negative scalar or 3-vector - cylinder(): h must be positive, r1/r2 must be non-negative - sphere(): r must be non-negative This follows the pattern already established by cuboid(), prismoid(), rect_tube() and wedge() which have comprehensive validation. Ref: BelfrySCAD#108
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assert()parameter validation tocube(): checkssizeis a valid 3-vector with non-negative valuesassert()parameter validation tocylinder(): checksh > 0,r1 >= 0,r2 >= 0assert()parameter validation tosphere(): checksr >= 0Test plan
Addresses #108
🤖 Generated with Claude Code