test: add edge case coverage for transform and vector functions (#231)#1958
Open
junhinhow wants to merge 2 commits intoBelfrySCAD:masterfrom
Open
test: add edge case coverage for transform and vector functions (#231)#1958junhinhow wants to merge 2 commits intoBelfrySCAD:masterfrom
junhinhow wants to merge 2 commits intoBelfrySCAD:masterfrom
Conversation
Expanded tests for translate, move, scale, mirror, xflip, yflip, zflip, skew, and frame_map with edge cases including: - 2D vector inputs - Zero/identity values - Negative values - Large values - Double-operation identity (mirror*mirror = I) - Composition properties (move(a)*move(b) = move(a+b)) - List of points transformations - Angle-based skew parameters Total new asserts: ~74 across 9 test functions. Ref: BelfrySCAD#231
Expanded tests for unit, v_abs, v_floor, v_ceil, v_mul, v_div, v_theta, and add_scalar with edge cases including: - Zero vectors (2D and 3D) - Negative values - Already-normalized vectors - Large and small magnitude values - 2D vs 3D inputs - Fractional and boundary values - Self-division identity - Precise angle calculations Total new asserts: ~80 across 8 test functions. Ref: BelfrySCAD#231
Collaborator
|
A general observation is that you're generating a ton of AI produced PRs and they all need to be examined to figure out what they do and if they have any issues, which requires human effort. Also we need comments to be in English, not Portuguese. |
Author
|
Thanks for the feedback, Adrian! You're right on both points. I've already updated all commit messages and comments to English across all PRs — that's fixed now. Regarding the volume: I apologize for the burst of PRs. The intention was just to contribute where I could across the open issues. There's absolutely no rush to review any of these — please take your time and go through them at whatever pace works for you. Happy to address any issues or questions you find along the way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Addresses #231
🤖 Generated with Claude Code