fix: correct partition_mask edge clipping (#1754)#1966
Open
junhinhow wants to merge 1 commit intoBelfrySCAD:masterfrom
Open
fix: correct partition_mask edge clipping (#1754)#1966junhinhow wants to merge 1 commit intoBelfrySCAD:masterfrom
junhinhow wants to merge 1 commit intoBelfrySCAD:masterfrom
Conversation
The _partition_cutpath() function used ceil() to calculate repetitions, producing patterns larger than available space and then truncating with index logic (stidxs/enidxs), causing visual artifacts at the edges. Fixes: - Use floor() to ensure repetitions fit within available space - Reduce reps (instead of increasing) when cutpath_centered with even count - Calculate cplen correctly: reps*cutsize.x + (reps-1)*gap - Remove truncation logic (stidxs/enidxs) that was a band-aid - Limit right edge to cplen/2 instead of l/2 Fix based on analysis from the issue author.
junhinhow
force-pushed
the
fix/partition-clipping-1754
branch
from
eeb75c3 to
16a9654
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code