feat: refactor ball_bearing_info() to return struct (#1933)#1968
Open
junhinhow wants to merge 1 commit intoBelfrySCAD:masterfrom
Open
feat: refactor ball_bearing_info() to return struct (#1933)#1968junhinhow wants to merge 1 commit intoBelfrySCAD:masterfrom
junhinhow wants to merge 1 commit intoBelfrySCAD:masterfrom
Conversation
Change ball_bearing_info() return value from positional array to named struct using BOSL2 struct pattern (list of [key, value] pairs). Keys: "bore", "outer_diam", "width", "shield_diam", "inner_race_diam", "inner_race_width", "outer_race_diam", "outer_race_width", "ball_diam", "ball_count", "fill_factor" Update ball_bearing() module to use struct_val() instead of array indexing. Update documentation to describe struct keys. Improves API consistency and readability (named fields vs magic indices).
ebd54c8 to
485fd35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code